Bug 988181 - New version request
Summary: New version request
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: acpi
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Johan Swensson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-25 02:45 UTC by Christopher Meng
Modified: 2013-11-10 07:32 UTC (History)
2 users (show)

Fixed In Version: acpi-1.6-3.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-08 04:38:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christopher Meng 2013-07-25 02:45:32 UTC
Hi,

I'm packaging a software which requires this, I hope you can update it to the latest version.

And your spec is not good.

Please fix:

1. Remove BuildRoot tag.

2. Source0 should be viable.

See: http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

3. Remove rm -rf $RPM_BUILD_ROOT in %install section.

4. Remove whole %clean section.

5. Remove defattr in %files section.

Thanks again!

Comment 1 Fedora End Of Life 2013-09-16 14:46:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 2 Johan Swensson 2013-10-17 09:39:09 UTC
I've taken the liberty to create an update for this package.
I'm not a current packager but trying to learn so it might not be perfect.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6069612
SPEC: http://kupo.se/pub/acpi/acpi.spec
SRPM: http://kupo.se/pub/acpi/acpi-1.6-1.fc19.src.rpm

Comment 3 Michael Schwendt 2013-10-21 15:04:57 UTC
It's a tiny package, but:

* Run rpmlint (or rpmlint -i for more helpful output) on the src.rpm and all
built rpms. Feel free to ignore obvious false positives in the report, but fix
anything else. Preferably add a comment here about whether/when you think what
rpmlint reports is correct or incorrect.


> %{_datadir}/man/man1/acpi.1.gz

A growing number of reviewers suggest replacing the '.gz' with '*', because that makes it possible to disable/change/customise the compression that is applied by rpmbuild on-the-fly.

Comment 4 Johan Swensson 2013-10-21 16:22:37 UTC
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6084169
SPEC: http://kupo.se/pub/acpi/acpi.spec
SRPM: http://kupo.se/pub/acpi/acpi-1.6-2.fc19.src.rpm

%changelog
* Mon Oct 21 2013 kupo <kupo> - 1.6-2
- Changed man file path from datadir to use mandir instead and replaced .gz with *

rpmlint:
acpi.src: W: name-repeated-in-summary C ACPI
acpi.src: W: name-repeated-in-summary pl ACPI
acpi.src: W: spelling-error %description -l en_US apm -> amp, am, pm
acpi.src: W: spelling-error %description -l pl apm -> AMP, AM, AP
acpi.x86_64: W: name-repeated-in-summary C ACPI
acpi.x86_64: W: name-repeated-in-summary pl ACPI
acpi.x86_64: W: spelling-error %description -l en_US apm -> amp, am, pm
acpi.x86_64: W: spelling-error %description -l pl apm -> AMP, AM, AP
acpi.x86_64: E: incorrect-fsf-address /usr/share/doc/acpi-1.6/COPYING
acpi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/acpi-1.6/list.c
acpi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/acpi-1.6/acpi.c
acpi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/acpi-1.6/acpi.h
acpi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/acpi-1.6/list.h
acpi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/acpi-1.6/main.c
3 packages and 1 specfiles checked; 6 errors, 8 warnings.

I'm assuming no one have informed upstream regarding the incorrect-fsf-address as they were present in the previous version as well or they have simply not fixed it yet.
The other issues seems like non-issues to me, correct me if I'm wrong.
I guess I could rewrite the English summary a little but that would leave the Polish one out of sync as I don't know any Polish. :)

Comment 5 Christopher Meng 2013-10-22 15:26:37 UTC
Just notify upstream about the incorrect FSF addr issue is OK.

(I think putting URL ABOVE SourceX is more common).

When you get the privilege of pushing updates, please use Bodhi to notify us.

Thanks.

Comment 6 Johan Swensson 2013-10-22 18:37:48 UTC
Thank you, I will.
I pinged the current maintainer a week ago by email but have not received any response yet. He have not been very active recently.

Comment 7 Michael Schwendt 2013-10-22 18:55:31 UTC
> The other issues seems like non-issues to me,

Correct. They are false positives.

Comment 8 Fedora Update System 2013-10-29 21:55:30 UTC
acpi-1.6-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/acpi-1.6-2.fc20

Comment 9 Fedora Update System 2013-10-30 06:57:36 UTC
acpi-1.6-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/acpi-1.6-3.fc20

Comment 10 Fedora Update System 2013-10-30 08:40:03 UTC
acpi-1.6-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/acpi-1.6-3.fc19

Comment 11 Fedora Update System 2013-10-30 17:11:23 UTC
Package acpi-1.6-3.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing acpi-1.6-3.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-20322/acpi-1.6-3.fc20
then log in and leave karma (feedback).

Comment 12 Fedora Update System 2013-11-08 04:38:11 UTC
acpi-1.6-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2013-11-10 07:32:25 UTC
acpi-1.6-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.