Bug 988216

I think these are two different issues.

The first issue is because there are no required transformations required for the application.  I agree that this is a deficit in the tooling and we should allow users to create transformers for random types.

I cannot reproduce the second issue, so I will need more detailed steps to reproduce.  Here's what I tried:
1. Create a Java component.
2. Add a reference to the component created in step 1.
3. Create a Camel component, which implements an ESB interface whose service name matches the reference added in step 2.  The camel component's service should be automatically wired to the bean component's reference upon completion.
4. An error should appear stating that a transformer is required.  A walk through the wizard brought up by "create required transformers" creates and adds the transformers to the application and the error disappears.

Rob

I tried the steps described by Rob and it does not work for me. No error appears and no wizard is started - I think we need to do a VNC session to demonstrate the issue

Jiri, could you please attache the project you are testing with?  Thanks.

Created attachment 799127 [details]
Reproducer

Project attached - see that reference and service have incompatible interfaces but no transformation is required according to JBDS

Brian Fitzpatrick <bfitzpat> made a comment on jira SWITCHYARD-1661

Ok, so there are two pieces to this issue it seems.

One, users should be able to add transformers even if they're not required. At one point we had that functionality, but we removed it in favor of the wizard-based required approach. We'll see what we can do to add that ability back in.

Two, I'm able to somewhat reproduce the issue Jiri is seeing with the sample project he posted. Thanks for that. Even if I add two JSON transformers to "match" the missing ones:

{code}
  <transforms>
    <transform:transform.json from="java:java.lang.Integer" to="{urn:my:servive}in"/>
    <transform:transform.json from="{urn:my:servive}out" to="java:java.lang.String"/>
  </transforms>
{code}

I'm still getting validation errors here, so I need to dig deeper and see what's going on.

(In reply to JBoss JIRA Server from comment #6)
> Brian Fitzpatrick <bfitzpat> made a comment on jira
> SWITCHYARD-1661
> 
> Ok, so there are two pieces to this issue it seems.
> 
> One, users should be able to add transformers even if they're not required.
> At one point we had that functionality, but we removed it in favor of the
> wizard-based required approach. We'll see what we can do to add that ability
> back in.
> 

This would be an enhancement, which should be tracked in a separate issue.  At this point in time, I think that would be out of scope for GA, but once the other issue is created, we can let PM, QA and DEV decide when it needs to be addressed.

From Rob, if you re-validate, you still get the errors, but it doesn't prevent you from deploying and running.

From ALT: Please split into two Bugzillas.

Rob Cernich <rcernich> made a comment on jira SWITCHYARD-1661

Looks like SwitchYardModelUtils.getServiceInterface() is using new QName() instead of QName.valueOf() to create the QName objects for ESB operation types.

Feature request moved to bz1013997

(In reply to Anne-Louise Tangring from comment #8)
> From Rob, if you re-validate, you still get the errors, but it doesn't
> prevent you from deploying and running.
> 
> From ALT: Please split into two Bugzillas.

Brian Fitzpatrick <bfitzpat> made a comment on jira SWITCHYARD-1661

Implemented Rob's fix in this PR

Rob Cernich <rcernich> made a comment on jira SWITCHYARD-1661

pushed

Verified with JBDS-IS 7.0.0.CR2. 

Note that adding transformations for the same types is reported at https://bugzilla.redhat.com/show_bug.cgi?id=1013997

Keith Babo <kbabo> updated the status of jira SWITCHYARD-1661 to Closed