Bug 988456 - wesnoth-data owns some man page directories
Summary: wesnoth-data owns some man page directories
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: wesnoth
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-25 15:57 UTC by Steve Tyler
Modified: 2013-08-15 02:43 UTC (History)
3 users (show)

Fixed In Version: wesnoth-1.10.6-7.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-15 02:41:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
find-man-page-owners-1.sh shell script to find owners for all man pages in /usr/share/man (79 bytes, text/plain)
2013-07-31 19:55 UTC, Steve Tyler
no flags Details
man-page-ownership-4.txt (128.06 KB, text/plain)
2013-07-31 20:06 UTC, Steve Tyler
no flags Details
proposed wesnoth-1.10.6-6-man-page-ownership-1.patch (777 bytes, patch)
2013-07-31 21:24 UTC, Steve Tyler
no flags Details | Diff
man-page-ownership-5.txt (127.13 KB, text/plain)
2013-08-01 15:13 UTC, Steve Tyler
no flags Details

Description Steve Tyler 2013-07-25 15:57:38 UTC
Description of problem:
$ rpm -qf /usr/share/man/en_GB/
filesystem-3.1-2.fc18.x86_64
wesnoth-data-1.10.5-3.fc18.noarch

Version-Release number of selected component (if applicable):
wesnoth-data-1.10.5-3.fc18.noarch

How reproducible:
Always.

Steps to Reproduce:
1. $ sudo yum install wesnoth-data
2. $ rpm -qf /usr/share/man/en_GB/

Actual results:
/usr/share/man/en_GB/ is owned by wesnoth-data and filesystem:

$ rpm -qf /usr/share/man/en_GB/
filesystem-3.1-2.fc18.x86_64
wesnoth-data-1.10.5-3.fc18.noarch

Expected results:
/usr/share/man/en_GB/ is owned by filesystem alone.

Additional info:
New bug per Bug 905379, Comment 7:
Bug 905379 - Man-pages of wesnoth are in wrong directories and not gzipped

Comment 1 Gwyn Ciesla 2013-07-26 14:21:05 UTC
Fixed in rawhide, builds for f19 and f18 are coming.  It's a big package. :)

Comment 2 Fedora Update System 2013-07-26 15:25:51 UTC
wesnoth-1.10.6-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/wesnoth-1.10.6-4.fc19

Comment 3 Fedora Update System 2013-07-26 15:26:02 UTC
wesnoth-1.10.6-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/wesnoth-1.10.6-4.fc18

Comment 4 Steve Tyler 2013-07-26 16:38:12 UTC
There are some empty directories that are still owned by wesnoth-data:

[joeblow@f18-test-1 tmp]$ rpm -qf /usr/share/man/en_GB/man1
filesystem-3.1-2.fc18.x86_64
[joeblow@f18-test-1 tmp]$ rpm -qf /usr/share/man/en_GB/man6
filesystem-3.1-2.fc18.x86_64
wesnoth-data-1.10.6-4.fc18.noarch
[joeblow@f18-test-1 tmp]$ ls /usr/share/man/en_GB/man1
[joeblow@f18-test-1 tmp]$ ls /usr/share/man/en_GB/man6
[joeblow@f18-test-1 tmp]$ rpm -qa 'wes*' | sort
wesnoth-1.10.6-4.fc18.x86_64
wesnoth-data-1.10.6-4.fc18.noarch

The package doesn't have them, though:
[joeblow@f18-test-1 tmp]$ rpm -ql westnoth-data | grep man1
[joeblow@f18-test-1 tmp]$ rpm -ql westnoth-data | grep man6

For testing, I first installed wesnoth-data from updates and then ran yum update on the new rpms:

[joeblow@f18-test-1 tmp]$ sudo grep wesnoth /var/log/yum.log 
Jul 25 01:07:30 Installed: wesnoth-data-1.10.5-3.fc18.noarch
Jul 25 01:07:36 Installed: wesnoth-1.10.5-3.fc18.x86_64
Jul 25 01:42:49 Erased: wesnoth-data-1.10.5-3.fc18.noarch
Jul 25 01:42:51 Erased: wesnoth-1.10.5-3.fc18.x86_64
Jul 26 09:04:14 Installed: wesnoth-data-1.10.5-3.fc18.noarch
Jul 26 09:04:20 Installed: wesnoth-1.10.5-3.fc18.x86_64
Jul 26 09:18:51 Updated: wesnoth-1.10.6-4.fc18.x86_64
Jul 26 09:19:36 Updated: wesnoth-data-1.10.6-4.fc18.noarch

Comment 5 Gwyn Ciesla 2013-07-26 16:40:23 UTC
[joeblow@f18-test-1 tmp]$ rpm -ql westnoth-data | grep man1

Should be

[joeblow@f18-test-1 tmp]$ rpm -ql wesnoth-data | grep man1

Comment 6 Steve Tyler 2013-07-26 18:39:51 UTC
Thanks for pointing that out:
[joeblow@f18-test-1 ~]$ rpm -ql wesnoth-data | grep man1 | wc -l
0
[joeblow@f18-test-1 ~]$ rpm -ql wesnoth-data | grep man6 | wc -l
28

Comment 7 Fedora Update System 2013-07-26 23:03:13 UTC
Package wesnoth-1.10.6-4.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing wesnoth-1.10.6-4.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-13701/wesnoth-1.10.6-4.fc18
then log in and leave karma (feedback).

Comment 8 Steve Tyler 2013-07-29 03:20:47 UTC
Here is a comprehensive test of man page and man directory ownership:

$ rpm -qf $(rpm -ql wesnoth-data | grep /usr/share/man) | sort -u
filesystem-3.2-13.fc19.x86_64
wesnoth-data-1.10.6-4.fc19.noarch

Comment 9 Steve Tyler 2013-07-29 03:44:35 UTC
(In reply to Steve Tyler from comment #8)
> Here is a comprehensive test of man page and man directory ownership:
> 
> $ rpm -qf $(rpm -ql wesnoth-data | grep /usr/share/man) | sort -u
> filesystem-3.2-13.fc19.x86_64
> wesnoth-data-1.10.6-4.fc19.noarch

Based on this result, the bug state should be returned to ASSIGNED.

Comment 10 Steve Tyler 2013-07-31 19:05:21 UTC
wesnoth-data-1.10.6-7 does not fix the man page ownership problem:

# rpm -qf $(rpm -ql wesnoth-data | grep /usr/share/man) | sort -u
filesystem-3.2-17.fc20.x86_64
wesnoth-data-1.10.6-7.fc20.noarch

Comment 11 Steve Tyler 2013-07-31 19:20:46 UTC
I think it's this one:

# rpm -qf /usr/share/man/man6
filesystem-3.2-17.fc20.x86_64
wesnoth-data-1.10.6-7.fc20.noarch

The spec file has:
%{_mandir}/man6

I know zero about spec files, but maybe that should be:
%{_mandir}/man6/*

Comment 12 Steve Tyler 2013-07-31 19:30:37 UTC
The spec file is listing all 28 man directories. This is going to break, if upstream adds translation number 29. Isn't there a more robust way to do this?

Snippet from wesnoth.spec:
http://pkgs.fedoraproject.org/cgit/wesnoth.git/plain/wesnoth.spec
...
%{_mandir}/cs/*
%{_mandir}/de/*
%{_mandir}/en_GB/*
%{_mandir}/es/*
%{_mandir}/et/*
%{_mandir}/fi/*
%{_mandir}/fr/*
%{_mandir}/gl/*
%{_mandir}/hu/*
%{_mandir}/id/*
%{_mandir}/it/*
%{_mandir}/ja/*
%{_mandir}/lt/*
%{_mandir}/man6
%{_mandir}/pl/*
%{_mandir}/pt/*
%{_mandir}/pt_BR/*
%{_mandir}/ru/*
%{_mandir}/sk/*
%{_mandir}/sr/*
%{_mandir}/sr@ijekavian/*
%{_mandir}/sr@ijekavianlatin/*
%{_mandir}/sr@latin/*
%{_mandir}/tr/*
%{_mandir}/uk/*
%{_mandir}/vi/*
%{_mandir}/zh_CN/*
%{_mandir}/zh_TW/*
...

Comment 13 Steve Tyler 2013-07-31 19:55:37 UTC
Created attachment 781344 [details]
find-man-page-owners-1.sh shell script to find owners for all man pages in /usr/share/man

Usage:
$ ./find-man-page-owners-1.sh > man-page-owners-1.txt

Comment 14 Steve Tyler 2013-07-31 20:06:43 UTC
Created attachment 781345 [details]
man-page-ownership-4.txt

This is a list of owners for each man page and man directory in a minimal system with wesnoth-data installed.

The 28 man6 directories are all owned by wesnoth-data and filesystem:

$ cat man-page-ownership-4.txt | grep wesnoth | grep filesystem | wc -l
28
$ cat man-page-ownership-4.txt | grep wesnoth | grep filesystem
/usr/share/man/sr/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/en_GB/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/sr@ijekavian/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/it/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/cs/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/sr@ijekavianlatin/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/sk/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/hu/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/id/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/fi/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/pt/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/es/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/gl/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/pl/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/de/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/et/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/uk/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/ja/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/sr@latin/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/pt_BR/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/fr/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/lt/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/zh_CN/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/vi/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/tr/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/zh_TW/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch
/usr/share/man/ru/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch

Comment 15 Steve Tyler 2013-07-31 20:12:25 UTC
The 28 directories include /usr/share/man/man6:

/usr/share/man/man6: filesystem-3.2-17.fc20.x86_64 wesnoth-data-1.10.6-7.fc20.noarch

Comment 16 Steve Tyler 2013-07-31 20:54:48 UTC
This might work:
%{_mandir}/man6/*
%{_mandir}/*/man6/*

How to create an RPM package
SPEC file overview 
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview

Examples from git:
http://pkgs.fedoraproject.org/cgit/NetworkManager.git/tree/NetworkManager.spec
%{_mandir}/man1/*
%{_mandir}/man5/*
%{_mandir}/man8/*

http://pkgs.fedoraproject.org/cgit/coreutils.git/tree/coreutils.spec
%{_mandir}/man*/*

http://pkgs.fedoraproject.org/cgit/man-pages.git/tree/man-pages.spec
%{_mandir}/man*/*
%lang(en) %{_mandir}/en/man*/*

http://pkgs.fedoraproject.org/cgit/man-pages-fr.git/tree/man-pages-fr.spec
%{_mandir}/fr/man?/*

Comment 17 Steve Tyler 2013-07-31 21:24:25 UTC
Created attachment 781375 [details]
proposed wesnoth-1.10.6-6-man-page-ownership-1.patch

Proposed patch to fix man page ownership.

Disclaimer: This is completely untested.

Comment 18 Gwyn Ciesla 2013-08-01 14:29:55 UTC
Ok, the RPMs at http://fedorapeople.org/~limb/wesnoth/ have been updated.

Comment 19 Steve Tyler 2013-08-01 14:40:38 UTC
(In reply to Jon Ciesla from comment #18)
> Ok, the RPMs at http://fedorapeople.org/~limb/wesnoth/ have been updated.

Thanks.

Comment 20 Steve Tyler 2013-08-01 15:13:46 UTC
Created attachment 781653 [details]
man-page-ownership-5.txt

This looks good:

No man files or directories have wesnoth and filesystem as owners.
No man page directories are owned by wesnoth.
There are 53 man page files owned by wesnoth.

$ cat man-page-ownership-5.txt | grep wesnoth | grep filesystem | wc -l
0
$ cat man-page-ownership-5.txt | grep wesnoth | grep '^d' | wc -l
0
$ cat man-page-ownership-5.txt | grep wesnoth | grep -v '^d' | wc -l
53
$ cat man-page-ownership-5.txt | grep filesystem | wc -l
148

Comment 21 Steve Tyler 2013-08-01 15:23:05 UTC
I was supposed to be checking with wesnoth-data, but the results are the same.

Let me know when you start a koji build.

$ cat man-page-ownership-5.txt | grep wesnoth-data | grep filesystem | wc -l
0
$ cat man-page-ownership-5.txt | grep wesnoth-data | wc -l
53

Comment 22 Gwyn Ciesla 2013-08-01 16:15:21 UTC
Excellent, I'll get this out.  Thanks for your help!

Comment 23 Fedora Update System 2013-08-01 17:32:49 UTC
wesnoth-1.10.6-7.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/wesnoth-1.10.6-7.fc19

Comment 24 Fedora Update System 2013-08-01 17:33:03 UTC
wesnoth-1.10.6-7.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/wesnoth-1.10.6-7.fc18

Comment 25 Fedora Update System 2013-08-15 02:41:42 UTC
wesnoth-1.10.6-7.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 26 Fedora Update System 2013-08-15 02:43:55 UTC
wesnoth-1.10.6-7.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.