Red Hat Bugzilla – Bug 989775
Review Request: rubygem-omniauth - A generalized Rack framework for multiple-provider authentication
Last modified: 2013-10-02 02:49:53 EDT
Spec URL: http://axilleas.fedorapeople.org/pkgs/rubygem-omniauth/rubygem-omniauth.spec
SRPM URL: http://axilleas.fedorapeople.org/pkgs/rubygem-omniauth/rubygem-omniauth-1.1.4-1.fc19.src.rpm
Description: A generalized Rack framework for multiple-provider authentication
Fedora Account System Username: axilleas
* The package is properly named
* Versioning is sane
* License is fine
* SPEC file is clean and legible
* RPMlint is happy
* Builds fine in mock
* Source file matches upstream
* Requires sane
* Provides sane
* Filelist sane
1.) No need to explicitely set noarch here
2.) It's probably not a good idea to modify the files in build tree from check.
%prep is better suited for this purpose:
# Remove unneeded coveralls
sed -i '/[Cc]overalls/d' spec/helper.rb
3.) Keeping README in -doc subpackage is a bad idea
...despite what some Ruby packagers unaware of RPM transaction flags think :(
Please move it into the main package. User should not need to install a
subpackage to learn important information about the main package.
Thanks for the review :)
New koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5859513
Also could you elaborate on the README and the `RPM transaction flags` you mentioned? Thank you :)
(In reply to Axilleas Pipinellis from comment #3)
> Also could you elaborate on the README and the `RPM transaction flags` you
> mentioned? Thank you :)
See "rpm --excludedocs" and "tsflags" in yum.conf(5).
Thank you for addressing the issues, the package looks fine to me now.
Sorry for the late reply, thanks for the review :)
New Package SCM Request
Package Name: rubygem-omniauth
Short Description: A generalized Rack framework for multiple-provider authentication
Branches: f19 f20
Git done (by process-git-requests).
rubygem-omniauth-1.1.4-2.fc20 has been submitted as an update for Fedora 20.
rubygem-omniauth-1.1.4-2.fc19 has been submitted as an update for Fedora 19.
rubygem-omniauth-1.1.4-2.fc20 has been pushed to the Fedora 20 testing repository.
rubygem-omniauth-1.1.4-2.fc19 has been pushed to the Fedora 19 stable repository.
rubygem-omniauth-1.1.4-2.fc20 has been pushed to the Fedora 20 stable repository.