Spec URL: http://vicodan.fedorapeople.org/matespec/mate-icon-theme-faenza.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-icon-theme-faenza-1.6.0-1.fc19.src.rpm Description: Provides a complimentary set of icon themes for MATE Desktop successful rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=5673981
Where is the changelog?
Two suggestions. 1. You don't need BR icon-naming-utils. 2. This is a very big package, you can use hardlink to link identical images to reduce the package size. Add BuildRequires: hardlink and before rpm scriplets. # save space by linking identical images hardlink -c -v $RPM_BUILD_ROOT%{_datadir}/icons
sorry , i meant # save space by linking identical images hardlink -c -v %{buildroot}%{_datadir}/icons
(In reply to Christopher Meng from comment #1) > Where is the changelog? Changelog for what?
(In reply to Dan Mashal from comment #4) > (In reply to Christopher Meng from comment #1) > > Where is the changelog? > > Changelog for what? For what? You dont know for what? You don't know how to write %changelog? Are you kidding me?
(In reply to Christopher Meng from comment #5) > (In reply to Dan Mashal from comment #4) > > (In reply to Christopher Meng from comment #1) > > > Where is the changelog? > > > > Changelog for what? > > For what? You dont know for what? > > You don't know how to write %changelog? Are you kidding me? Please step aside. Instead of being rude you could have been more specific. I want Wolfgang to do this review you could have been more specific. Wolfgang is mycomaintainer for MATE and is experienced in doing package reviews. Wolfgang please take this review.
@ Christopher, i can take the review if it is no problem for you.
I've updated the spec and srpm. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-icon-theme-faenza.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-icon-theme-faenza-1.6.0-1.fc19.src.rpm Description: Provides a complimentary set of icon themes for MATE Desktop
Created attachment 915741 [details] Comment (This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).
New Package SCM Request ======================= Package Name: mate-icon-theme-faenza Short Description: Complementary icon theme for MATE Desktop Owners: viocdan raveit65 Branches: f18 f19
@Limb: Also please add rdieter as an owner. Thanks
Git done (by process-git-requests). Added rdieter, corrected vicodan spelling.
mate-icon-theme-faenza-1.6.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mate-icon-theme-faenza-1.6.0-1.fc19
mate-icon-theme-faenza-1.6.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-icon-theme-faenza-1.6.0-1.fc18
mate-icon-theme-faenza-1.6.0-1.fc18 has been pushed to the Fedora 18 testing repository.
mate-icon-theme-faenza-1.6.0-1.fc19 has been pushed to the Fedora 19 stable repository.
mate-icon-theme-faenza-1.6.0-1.fc18 has been pushed to the Fedora 18 stable repository.