Red Hat Bugzilla – Bug 990200
Static Analysis cleanup of lower risk items
Last modified: 2013-08-01 09:09:51 EDT
Description of problem: OverviewForm.java:134, DLS_DEAD_LOCAL_STORE, Priority: High
OverviewForm.java:134, DLS_DEAD_LOCAL_STORE, Priority: High
Dead store to notNullValidator in org.rhq.enterprise.gui.coregui.client.inventory.resource.detail.OverviewForm.buildForm(ResourceType)
This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
At the Static Code Analysis review meeting, MikeT stated he would like to address this.
As this was such a small issue I have included most the:
Category MALICIOUS_CODE - Type MS_SHOULD_BE_FINAL
This should cleanup the stats (and code) a bit. This stuff was not major but the report is technically correct. Mostly the portlet static factories that should have final static instances since they are static inner classes were scrubbed. And cleaner code is always good.
We should always strive for ways that objectively (via tools) tells us about our code quality.
This was committed to master with commit id: 300fe85.
These changes will be covered by automated tests, regression tests. No specific QE tasks required.