Spec URL: http://ignatenkobrain.fedorapeople.org/for-review/json-parser.spec SRPM URL: http://ignatenkobrain.fedorapeople.org/for-review/json-parser-1.0.0-1.9fcf518.fc19.src.rpm Description: Very low footprint JSON parser written in portable ANSI C Fedora Account System Username: ignatenkobrain Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5684192
quickies: * lacks a comment explaining how the tarball has been generated (either provide a script or a command-line) * python wrapper not included * tests (depending on the aforementioned python wrapper) missing too * you should request upstream maintainer to add a license file in his repository (and release tarballs when they'll be available)
I recommend you to move %post{un} scripts below install section and above file's section.
(In reply to Christopher Meng from comment #2) > I recommend you to move %post{un} scripts below install section and above > file's section. fxd (In reply to Haïkel Guémar from comment #1) > quickies: > * lacks a comment explaining how the tarball has been generated (either > provide a script or a command-line) Simple download > * python wrapper not included In future will deleted > * tests (depending on the aforementioned python wrapper) missing too In future will fixed > * you should request upstream maintainer to add a license file in his > repository (and release tarballs when they'll be available) fxd new spec: http://ignatenkobrain.fedorapeople.org/for-review/json-parser.spec new srpm: http://ignatenkobrain.fedorapeople.org/for-review/json-parser-1.0.0-1.df38ae7.fc19.src.rpm
* current spec seems OK (i also reviewed the code, seems OK too) * i found out that the shared library generated was an empty stub, i submitted a Pull Request that fixes it https://github.com/udp/json-parser/pull/31 * i'll continue testing the library itself
(In reply to Haïkel Guémar from comment #4) > * current spec seems OK (i also reviewed the code, seems OK too) > * i found out that the shared library generated was an empty stub, i > submitted a Pull Request that fixes it > https://github.com/udp/json-parser/pull/31 merged and updated > * i'll continue testing the library itself new spec: http://ignatenkobrain.fedorapeople.org/for-review/json-parser.spec new srpm: http://ignatenkobrain.fedorapeople.org/for-review/json-parser-1.0.0-3.13ef5a8.fc19.src.rpm
* code review: OK * shared library issue: OK (PR accepted and package updated) * working package: OK (i wrote a sample C program that parses a JSON file for testing purpose) Since this package now complies with Fedora packaging guidelines, i hereby approve it into Fedora Packages Collection. I advise you to continue working with upstream on the test suite, it will ensure that the library won't get any regression and keep working in the future (and save time for upstream by noticing them faster). Let me know if you experience issues in importing this package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/haikel/json-parser/990624-json- parser/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: json-parser-1.0.0-3.13ef5a8.fc17.x86_64.rpm json-parser-devel-1.0.0-3.13ef5a8.fc17.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint json-parser json-parser-devel 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- json-parser (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) json-parser-devel (rpmlib, GLIBC filtered): json-parser(x86-64) libjsonparser.so.1.0()(64bit) Provides -------- json-parser: json-parser json-parser(x86-64) libjsonparser.so.1.0()(64bit) json-parser-devel: json-parser-devel json-parser-devel(x86-64) Source checksums ---------------- https://github.com/udp/json-parser/archive/13ef5a891d03caef0b93a65765f3d7ad03f94768/json-parser-1.0.0-13ef5a8.tar.gz : CHECKSUM(SHA256) this package : 6d07ed83a56ae7969877ecc16b2405bc0f97000711916d464dcaf9db3af2ecbb CHECKSUM(SHA256) upstream package : 6d07ed83a56ae7969877ecc16b2405bc0f97000711916d464dcaf9db3af2ecbb Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 990624
New Package SCM Request ======================= Package Name: json-parser Short Description: Very low footprint JSON parser written in portable ANSI C Owners: ignatenkobrain Branches: f19
Git done (by process-git-requests).
json-parser-1.0.0-3.13ef5a8.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/json-parser-1.0.0-3.13ef5a8.fc19
Something for a future update: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing
json-parser-1.0.0-3.13ef5a8.fc19 has been pushed to the Fedora 19 testing repository.
json-parser-1.0.0-3.13ef5a8.fc19 has been pushed to the Fedora 19 stable repository.