Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://otherwiseguy.fedorapeople.org/openstack-neutron.spec SRPM URL: http://otherwiseguy.fedorapeople.org/openstack-neutron-2013.2-0.1.b2.fc19.src.rpm Description: Neutron is a virtual network service for Openstack. Just like OpenStack Nova provides an API to dynamically request and configure virtual servers, Neutron provides an API to dynamically request and configure virtual networks. These networks connect "interfaces" from other OpenStack services (e.g., virtual NICs from Nova VMs). The Neutron API supports extensions to provide advanced network capabilities (e.g., QoS, ACLs, network monitoring, etc.) Fedora Account System Username: otherwiseguy
So that version progress upwards: s/Release: 0.1.b2/Release: 0.3.b2/ Fixing obsoletes number and - issue: s/Obsoletes: openstack-quantum < 2013.2.0.1.b2/ Obsoletes: openstack-quantum < 2013.2-0.2.b2/ Ditto for each subpackage I see `groupadd` has -o to allow quantum and neutron share the name Otherwise it looks like s/quantum/neutron/ For my reference I notice that quantum-* compat commands are being provided by neutron upstream I also notice %{python_sitelib}/quantum is still referenced, I suppose as a compat redirection to neutron Please delete the references to quantum-*-setup rather than commenting
Updated to address pbrady's review: http://otherwiseguy.fedorapeople.org/openstack-neutron-2013.2-0.3.b2.fc19.src.rpm http://otherwiseguy.fedorapeople.org/openstack-neutron.spec
(and yes, %{python_sitelib}/quantum has an API compat layer upstream)
some rpmlint: openstack-neutron.src: W: strange-permission neutron-dhcp-setup 0775L openstack-neutron.src: W: strange-permission neutron-l3-setup 0775L openstack-neutron.src: W: strange-permission neutron-node-setup 0775L openstack-neutron.src: W: strange-permission neutron-server-setup 0775L openstack-neutron.src:18: W: macro-in-comment %{release_name} openstack-neutron.src:18: W: macro-in-comment %{version} openstack-neutron.src:18: W: macro-in-comment %{version} openstack-neutron.src:67: W: mixed-use-of-spaces-and-tabs (spaces: line 67, tab: line 6) openstack-neutron.src: W: invalid-url Source0: http://launchpad.net/neutron/havana/havana-1/+download/neutron-2013.2.b2.tar.gz HTTP Error 404: Not Found
Fixed rpmlint issues (except macro-in-comment as the Source0 comment is just to make it easier to fix things after the URL changes back to normal when we get out of the milestones).
Looks good thanks. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Apache (v2.0) MIT/X11 (BSD like)", "Unknown or generated", "*No copyright* Apache (v2.0)". 4 files have unknown license. Detailed output of licensecheck in /home/padraig/aa/review-openstack- neutron/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. [x]: Packages must not store files under /srv, /opt or /usr/local [-]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM.
New Package SCM Request ======================= Package Name: openstack-neutron Short Description: OpenStack Networking Service Owners: otherwiseguy Branches: el6
Git done (by process-git-requests).
Pádraig, during review please assign tickets to you. My Obsoletes checker reports: Only obsolete subpackage(s): ---------------------------- openstack-quantum ['openstack-quantum'] 15 left That means 15 subpackages from openstack-quantum are not obsoleted yet by their renamed subpackages: http://koji.fedoraproject.org/koji/buildinfo?buildID=457562
This should be fixed with build http://koji.fedoraproject.org/koji/buildinfo?buildID=459104
openstack-neutron-2013.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/FEDORA-2013-19509/openstack-neutron-2013.2-1.fc20
openstack-neutron-2013.2-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.