Bug 990817 - Review Request: python-x2go - Python module providing X2Go client API
Summary: Review Request: python-x2go - Python module providing X2Go client API
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 991286 991292 998551
TreeView+ depends on / blocked
 
Reported: 2013-08-01 04:21 UTC by Orion Poplawski
Modified: 2013-10-19 21:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-31 04:15:46 UTC
Type: ---
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Orion Poplawski 2013-08-01 04:21:56 UTC
Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/python-x2go.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/python-x2go-0.4.0.6-1.fc19.src.rpm
Description: 
X2Go is a server based computing environment with:
   - session resuming
   - low bandwidth support
   - LDAP support
   - client side mass storage mounting support
   - audio support
   - authentication by smartcard and USB stick

This Python module allows you to integrate X2Go client support into your
Python applications by providing a Python-based X2Go client API.

Fedora Account System Username: orion

Comment 1 Christopher Meng 2013-08-01 04:39:18 UTC
python-x2go.noarch: E: explicit-lib-dependency python-xlib
python-x2go.noarch: W: invalid-license AGPLv3+
python-x2go.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/x2go/forward.py 0644L /usr/bin/env
python-x2go.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/x2go/rforward.py 0644L /usr/bin/env
python-x2go.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/x2go/printactions.py 0644L /usr/bin/env
python-x2go.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/x2go/tests/runalltests.py 0644L /usr/bin/env
python-x2go.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/x2go/mimeboxactions.py 0644L /usr/bin/env
python-x2go.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/x2go/mimebox.py 0644L /usr/bin/env

Comment 2 Orion Poplawski 2013-08-01 20:43:34 UTC
(In reply to Christopher Meng from comment #1)
> python-x2go.noarch: E: explicit-lib-dependency python-xlib

False positive because of the "lib".  We still need to explicitly depend on python libraries.

> python-x2go.noarch: W: invalid-license AGPLv3+

It's listed here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses

> python-x2go.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/x2go/forward.py 0644L /usr/bin/env
> python-x2go.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/x2go/rforward.py 0644L /usr/bin/env
> python-x2go.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/x2go/printactions.py 0644L /usr/bin/env
> python-x2go.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/x2go/tests/runalltests.py 0644L /usr/bin/env
> python-x2go.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/x2go/mimeboxactions.py 0644L /usr/bin/env
> python-x2go.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/x2go/mimebox.py 0644L /usr/bin/env

Fixed.

Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/python-x2go.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/python-x2go-0.4.0.6-2.fc19.src.rpm

* Thu Aug 1 2013 Orion Poplawski <orion@cora.nwra.com> - 0.4.0.6-2
- Remove python shbangs from library scripts

Comment 3 Christopher Meng 2013-08-01 23:41:37 UTC
APPROVED.

Comment 4 Orion Poplawski 2013-08-02 03:57:13 UTC
New Package SCM Request
=======================
Package Name: python-x2go
Short Description: Python module providing X2Go client API
Owners: orion
Branches: f19 f18 el6
InitialCC:

Comment 5 Gwyn Ciesla 2013-08-02 12:03:25 UTC
Git done (by process-git-requests).

Comment 6 Orion Poplawski 2013-08-31 04:15:46 UTC
Checked in and built


Note You need to log in before you can comment on or make changes to this bug.