Bug 991319 - Review Request: python-applib - Cross-platform application utilities for Python originally implemented for PyPM
Summary: Review Request: python-applib - Cross-platform application utilities for Pyth...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 990236
TreeView+ depends on / blocked
 
Reported: 2013-08-02 06:51 UTC by Marcelo Barbosa "firemanxbr"
Modified: 2014-04-20 10:28 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-04-20 10:28:37 UTC
Type: Bug
Embargoed:
i: fedora-review?


Attachments (Terms of Use)

Description Marcelo Barbosa "firemanxbr" 2013-08-02 06:51:11 UTC
URL SPEC: http://firemanxbr.fedorapeople.org/packages/python-applib/python-applib.spec
URL SRPM: http://firemanxbr.fedorapeople.org/packages/python-applib/python-applib-1.2-1.fc19.src.rpm
Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5691048

Description: 
applib is a set of cross-platform application utilities that originated
in the PyPM project at ActiveState. It contains the following modules:

 * sh: shell related operations including compression routines
 * textui: utilities for textual UI such as progress bar and column printing
 * log: log file rolling, exception-and-verbosity, sub commands, etc.


Fedora Account System Username: firemanxbr

Comment 1 Christopher Meng 2013-08-05 02:42:54 UTC
python-applib.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/applib/_cmdln.py 0644L /usr/bin/env

And

Source checksums
----------------
https://github.com/ActiveState/applib/archive/3a24d82e98206e48091d41dd197a4a2dca3cf53d/applib-1.2-3a24d82.tar.gz :
  CHECKSUM(SHA256) this package     : 7a71581f985d31cc3f27259e4f958369b244d41009bdca2cfb823cb4592ade47
  CHECKSUM(SHA256) upstream package : 00fb72dbb5ac75018e3d4850dd0bfdc0f1013acf2e435712856671590a59d6e4

So as I've suggested, if upstream has a habit of refreshing their release without bumping the number, please use pypi as source.

Comment 2 Marcelo Barbosa "firemanxbr" 2013-08-19 17:47:42 UTC
Hi Cristopher,

   Thank your for review, my package is updated:

URL SPEC: http://firemanxbr.fedorapeople.org/packages/python-applib/python-applib.spec
URL SRPM: http://firemanxbr.fedorapeople.org/packages/python-applib/python-applib-1.2-2.fc19.src.rpm

Marcelo Barbosa (firemanxbr)

Comment 3 Christopher Meng 2013-08-20 01:50:47 UTC
Auh...

Why did you change it to 755?

1. Can it be executed? 

If so, chmod 755 AND CHANGE /USR/BIN/ENV TO /USR/BIN/PYTHON

2. If not, use define to remove the first line and report upstream.

Comment 4 Christopher Meng 2013-08-20 01:52:34 UTC
And why did you leave two files sections?

Comment 5 Marcelo Barbosa "firemanxbr" 2013-08-20 03:26:39 UTC
Hi Christopher,

 I updated, please review.

Marcelo Barbosa (firemanxbr)

Comment 6 Christopher Meng 2013-08-20 03:37:48 UTC
I can't see any updates, have you uploaded it?

Comment 7 Marcelo Barbosa "firemanxbr" 2013-08-20 03:42:37 UTC
yes, please clean your cache browser, i updated spec file and srpm.

Comment 8 Christopher Meng 2013-08-20 04:16:14 UTC
NO, of course not.

%files
%{_bindir}/%{name}


%files
%doc LICENSE.txt README.rst MANIFEST.in NEWS.txt
%{python_sitelib}/*

I still can see this.

And I think _cmdln.py is 644 perms.

Comment 9 Marcelo Barbosa "firemanxbr" 2013-08-20 04:36:56 UTC
Hi Christopher,

   Sorry my wrong, I updated all files, please try again.

Marcelo Barbosa (firemanxbr)

Comment 10 Christopher Meng 2013-08-20 04:40:52 UTC
Still need to be solved:

1. MANIFEST.in shouldn't be included as %doc, drop it.

2. Can you ensure that _cmdln.py is 755?

3. Even if it can be executed, I think we should to change env to python location.

Comment 11 Christopher Meng 2014-04-20 10:28:37 UTC
I've seen no interests nor activities on this.


Note You need to log in before you can comment on or make changes to this bug.