Bug 994039 - pidgin possibly affected by F-20 unversioned docdir change
Summary: pidgin possibly affected by F-20 unversioned docdir change
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: pidgin
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stu Tomlinson
QA Contact: Fedora Extras Quality Assurance
URL: http://fedoraproject.org/wiki/Changes...
Whiteboard:
Depends On:
Blocks: F20UnversionedDocDirs
TreeView+ depends on / blocked
 
Reported: 2013-08-06 14:01 UTC by Ville Skyttä
Modified: 2013-08-08 13:56 UTC (History)
3 users (show)

Fixed In Version: pidgin-2.10.7-8.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-08 13:56:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ville Skyttä 2013-08-06 14:01:24 UTC
pidgin was identified as a package possibly needing maintainer attention
due to the F-20 unversioned doc dir change. The identification is not
foolproof, it is basically this grep:

    grep -E "(/doc|_docdir|_defaultdocdir).+version" *.spec

Please review your package and make the appropriate changes, if any. A
good starting point is checking the lines output by the above grep for
your specfile. For the vast majority of packages, after the changes,
the expected outcome is that documentation dirs in /usr/share/doc
should no longer contain the package version.

More information and tips:
  https://fedoraproject.org/wiki/Changes/UnversionedDocdirs
  http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183943
  http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183973

Comment 1 Jan Synacek 2013-08-08 12:50:56 UTC
The docdir is already unversioned, nothing needs any intervention.

Comment 2 Ville Skyttä 2013-08-08 13:00:25 UTC
...but examining the suggested grep output would have revealed this:

$ grep -A 1 -B 1 -E "(/doc|_docdir|_defaultdocdir).+version" pidgin.spec 
mkdir -p $RPM_BUILD_ROOT%{_datadir}/gtk-doc/html/
ln -sf ../../doc/pidgin-docs-%{version}/html/ \
    $RPM_BUILD_ROOT%{_datadir}/gtk-doc/html/pidgin

Now that the docs are installed into an unversioned dir, that symlink is broken.

Comment 3 Jan Synacek 2013-08-08 13:56:27 UTC
Hmm, I completely oversaw that... It should be fixed now:

http://pkgs.fedoraproject.org/cgit/pidgin.git/commit/?id=ce71969dd2a5883dba76bf7292520c99814e46e9


Note You need to log in before you can comment on or make changes to this bug.