Bug 994308 - Review Request: perl-Proc-Queue - Limit the number of child processes running
Summary: Review Request: perl-Proc-Queue - Limit the number of child processes running
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
urgent
urgent
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-07 02:58 UTC by Christopher Meng
Modified: 2013-08-22 12:15 UTC (History)
3 users (show)

Fixed In Version: perl-Proc-Queue-1.23-1.fc19
Clone Of:
Environment:
Last Closed: 2013-08-18 21:37:23 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Christopher Meng 2013-08-07 02:58:42 UTC
Spec URL: http://cicku.me/perl-Proc-Queue.spec
SRPM URL: http://cicku.me/perl-Proc-Queue-1.23-1.fc20.src.rpm 
Description: This module lets you parallelise a perl program using the fork, exit, wait
and waitpid calls as usual but without taking care of creating too many
processes and overloading the machine.
Fedora Account System Username: cicku

Comment 1 Parag AN(पराग) 2013-08-07 03:38:17 UTC
Review:-

+ Package builds fine in mock (f20)

- rpmlint on generated rpms gave
perl-Proc-Queue.noarch: W: spelling-error %description -l en_US parallelise -> parallelism, paralleled, parallel
perl-Proc-Queue.noarch: W: spelling-error %description -l en_US waitpid -> wapiti
perl-Proc-Queue.noarch: W: file-not-utf8 /usr/share/doc/perl-Proc-Queue-1.23/README
perl-Proc-Queue.src: W: spelling-error %description -l en_US parallelise -> parallelism, paralleled, parallel
perl-Proc-Queue.src: W: spelling-error %description -l en_US waitpid -> wapiti
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ Source verified with upstream as (sha256sum)
upstream tarball :  3aca4e2a46b5c01498a446607a73f2c9121118a58cd670b3df285b6bca0d3f1c
srpm tarabll : 3aca4e2a46b5c01498a446607a73f2c9121118a58cd670b3df285b6bca0d3f1c

+ License is valid and include in source file.

+ make test gave
All tests successful.
Files=2, Tests=10, 21 wallclock secs ( 0.01 usr  0.00 sys +  0.04 cusr  0.04 csys =  0.09 CPU)

+ Package perl-Proc-Queue-1.23-1.fc20.noarch
Provides: perl(Proc::Queue) = 1.23 perl-Proc-Queue = 1.23-1.fc20
Requires: perl >= 0:5.006 perl(Carp) perl(Errno) perl(Exporter) perl(POSIX) perl(constant) perl(strict)


Suggestions:
1) rpmlint compains for README file as not utf8. Fix it in %prep as
iconv --from=ISO-8859-1 --to=UTF-8 README > README.new && \
touch -r README README.new && \
mv README.new README

APPROVED.

Comment 2 Christopher Meng 2013-08-07 04:44:36 UTC
Thanks! ;)

Comment 3 Christopher Meng 2013-08-07 04:45:45 UTC
New Package SCM Request
=======================
Package Name: perl-Proc-Queue
Short Description: Limit the number of child processes running
Owners: cicku
Branches: f18 f19
InitialCC:

Comment 4 Gwyn Ciesla 2013-08-07 12:19:59 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-08-07 23:57:38 UTC
perl-Proc-Queue-1.23-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Proc-Queue-1.23-1.fc19

Comment 6 Fedora Update System 2013-08-07 23:58:26 UTC
perl-Proc-Queue-1.23-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Proc-Queue-1.23-1.fc18

Comment 7 Fedora Update System 2013-08-09 16:59:16 UTC
perl-Proc-Queue-1.23-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 8 Fedora Update System 2013-08-18 21:37:23 UTC
perl-Proc-Queue-1.23-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 9 Fedora Update System 2013-08-18 21:38:40 UTC
perl-Proc-Queue-1.23-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 10 Christopher Meng 2013-08-22 09:08:07 UTC
Package Change Request
======================
Package Name: perl-Proc-Queue
New Branches: el6
Owners: cicku

Comment 11 Gwyn Ciesla 2013-08-22 12:15:05 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.