Bug 994429 (kcachegrind) - Review Request: kcachegrind - GUI to profilers such as Valgrind
Summary: Review Request: kcachegrind - GUI to profilers such as Valgrind
Keywords:
Status: CLOSED RAWHIDE
Alias: kcachegrind
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2013-08-07 09:22 UTC by Jan Grulich
Modified: 2013-08-14 13:16 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-14 13:16:39 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jan Grulich 2013-08-07 09:22:01 UTC
Spec URL: http://jgrulich.fedorapeople.org/kcachegrind.spec
SRPM URL: http://jgrulich.fedorapeople.org/kcachegrind-4.10.97-1.fc19.src.rpm
Description: Browser for data produced by profiling tools (e.g. cachegrind)
Fedora Account System Username: jgrulich

Successful build: 

This package was previously part of kdesdk. Now it's distributed separately in KDE 4.11.

Comment 1 Jan Grulich 2013-08-07 09:22:51 UTC
Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5788853

Comment 2 Rex Dieter 2013-08-13 22:00:02 UTC
naming: ok

1. license not ok, I see GPLv2 code + GFDL docs, so
License: GPLv2 and GFDL
and add
%doc COPYING.DOC

macros: ok

scriptlets ok

obsoletes/provides: ok

2. better url:
https://projects.kde.org/projects/kde/kdesdk/kcachegrind

 
as items 1,2 are mostly cosmetic, can be fixed post-review


APPROVED

Comment 3 Jan Grulich 2013-08-14 05:25:41 UTC
New Package SCM Request
=======================
Package Name: kcachegrind
Short Description:  GUI to profilers such as Valgrind
Owners: than rdieter kkofler ltinkl jgrulich
Branches: f18 f19
InitialCC:

Comment 4 Gwyn Ciesla 2013-08-14 12:50:01 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.