Bug 995836 - [command] remove the use of @LockIdNameAttribute
Summary: [command] remove the use of @LockIdNameAttribute
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.5.0
Assignee: Ravi Nori
QA Contact: Martin Mucha
URL:
Whiteboard: infra
Keywords: CodeChange
: 997376 (view as bug list)
Depends On:
Blocks: 997376 rhev3.5beta 1156165
TreeView+ depends on / blocked
 
Reported: 2013-08-11 12:08 UTC by Alon Bar-Lev
Modified: 2016-02-10 19:38 UTC (History)
10 users (show)

(edit)
Clone Of:
: 997376 (view as bug list)
(edit)
Last Closed: 2015-02-17 17:15:06 UTC


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 25944 master MERGED engine: remove the use of @LockIdNameAttribute Never
oVirt gerrit 25964 None ABANDONED engine: remove the use of @LockIdNameAttribute Never

Description Alon Bar-Lev 2013-08-11 12:08:15 UTC
Annotations should use behavior modification of reference objects, not as controller of logic paths witin inheritance.

@LockIdNameAttribute annotation is used to indicate incomplete logic requirement.

Each command inherit from CommandBase, and should override the getExclusiveLocks() method to acquire lock.

there is no point in having annotation for the CommandBase to call the getExclusiveLocks() or any other optional feature, as it can have its own embedded default implementations.

Comment 1 Yair Zaslavsky 2013-08-11 13:14:31 UTC
I would like to add that
annotations in java are not inherited .
Since we use inherience in the commands, this is a problem.

The problem exists in other commands - for example in AddDiskCommand.

Comment 2 Yair Zaslavsky 2013-08-11 13:18:48 UTC
Bare in mind that although the keywords, we have issues with current behavior of several commands.
This is why I acked this to 3.3.

Comment 3 Roy Golan 2013-08-11 14:04:49 UTC
grep "getExclusiveLocks" and extract what is missing @LockIdNameAttribute


bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java

Comment 4 Roy Golan 2013-08-11 14:12:35 UTC
just to make it clear, the storage commands are calling explicitly aquireLockInternal in the canDoAction. since there is no contract (no interface) we are open to mistakes and misuse. this should be rectified.

Comment 5 Yair Zaslavsky 2013-08-12 12:22:09 UTC
In reply to comment #3 -
Calling aquireLockInternal in CDA can still be risky, IMHO.
If we decide to postpone this from 3.3 - we should fix the above commands.

Comment 7 Yair Zaslavsky 2013-08-19 14:12:49 UTC
ExportRepoImageCommand has the annotation

Comment 8 Yair Zaslavsky 2013-08-19 14:16:16 UTC
It's also in all subclasses of RunVmCommandBase

Comment 9 Eli Mesika 2013-11-08 08:28:55 UTC
*** Bug 997376 has been marked as a duplicate of this bug. ***

Comment 11 Barak 2014-04-10 16:47:31 UTC
This is a bit late to get into 3.4 (2 weeks from RC) and this may be a bit riskey
Hence moving to 3.5

Comment 12 Eyal Edri 2015-02-17 17:15:06 UTC
rhev 3.5.0 was released. closing.


Note You need to log in before you can comment on or make changes to this bug.