Bug 995908 - Submitting a form after session expiration may result in an invalid redirect
Summary: Submitting a form after session expiration may result in an invalid redirect
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Fabiano Franz
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-12 00:26 UTC by Clayton Coleman
Modified: 2015-05-15 01:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-19 16:47:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Clayton Coleman 2013-08-12 00:26:29 UTC
When attempting to submit a form after the session has timed out (due to the auth token being deleted, for example), the redirect for logout logic will attempt to use the submitted page url to redirect to after login.  However, some common form POST urls have no GET equivalent, which causes the user to get sent to a non-existent page.

The logout logic should adjust the "then" parameter to ensure that the url is reachable via GET.  We probably don't want to get too complex (i.e. store the post as a cookie..), but we need to ensure the user can return to their page.

Comment 1 Fabiano Franz 2013-09-11 16:57:02 UTC
Pull request: https://github.com/openshift/li/pull/1887

Comment 3 Yujie Zhang 2013-09-12 03:40:28 UTC
Tested on devenv_3776, user will redirect to logged out page when submitting forms if session is expired, so verify this bug, thanks.


Note You need to log in before you can comment on or make changes to this bug.