Bug 996388 - [Review Feature] "Confirm rejection" should work with only reviewer role
[Review Feature] "Confirm rejection" should work with only reviewer role
Status: CLOSED CURRENTRELEASE
Product: Zanata
Classification: Community
Component: Component-UI (Show other bugs)
3.0
Unspecified Unspecified
unspecified Severity urgent
: ---
: 3.1
Assigned To: Patrick Huang
Zanata-QA Mailling List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-13 02:02 EDT by Ding-Yi Chen
Modified: 2013-11-26 22:35 EST (History)
3 users (show)

See Also:
Fixed In Version: 3.1-SNAPSHOT (20130822-1236)
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 996432 (view as bug list)
Environment:
Last Closed: 2013-11-26 22:25:00 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ding-Yi Chen 2013-08-13 02:02:14 EDT
Description of problem:
Reviewer only (has reviewer but not translator) role cannot reject translation,
because button "confirm reject" does not do anything. The user needs to click "cancel" to close the dialog.

Version-Release number of selected component (if applicable):
Zanata version 3.0.0-alpha-2-SNAPSHOT (20130813-1420)

How reproducible:
Always

Steps to Reproduce:
1. Login as a user with only reviewer role, but not translator role.
2. Go to Translation editor.
3. Find a non-empty translation, click Reject
4. Enter the comment: "Comment ver1" then click "Confirm rejection"

Actual results:
Nothing happened.

Expected results:
"Why is this translation rejected?" dialog should close, and comment count increase by one.

Additional info:
Comment 1 Sean Flanigan 2013-08-16 03:33:08 EDT
If we are talking about language reviewers (not project/technical reviewers, which aren't implemented yet), then I think it's okay to assume language reviewers are also translators.  So the workaround is for the team coordinator to make sure reviewers are translators too.
Comment 2 Sean Flanigan 2013-08-18 21:17:54 EDT
https://github.com/zanata/zanata-server/pull/130
Comment 3 Sean Flanigan 2013-08-21 21:50:34 EDT
The pull request has now been merged into integration/master (v3.1-SNAPSHOT).
Comment 4 Patrick Huang 2013-08-21 21:59:53 EDT
fixed in pull request:
https://github.com/zanata/zanata-server/pull/130
Comment 5 Ding-Yi Chen 2013-08-22 00:47:51 EDT
VERIFIED with Zanata version 3.1-SNAPSHOT (20130822-1236).
Comment 6 Sean Flanigan 2013-11-26 22:15:39 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 7 Sean Flanigan 2013-11-26 22:16:54 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 8 Sean Flanigan 2013-11-26 22:18:55 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 9 Sean Flanigan 2013-11-26 22:25:00 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 10 Sean Flanigan 2013-11-26 22:33:35 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 11 Sean Flanigan 2013-11-26 22:35:50 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.

Note You need to log in before you can comment on or make changes to this bug.