Provided links don't work

(In reply to Michael Simacek from comment #1)
> Provided links don't work

Spec URL: http://cicku.me/fix8.spec
SRPM URL: http://cicku.me/fix8-0.9.4-1.fc21.src.rpm

Prior to that this library has problem with gcc.

Will you review it?

I won't review it now because it doesn't build for me (amd64):
*** Error in `/home/msimacek/rpmbuild/BUILD/fix8-0.9.4/compiler/.libs/lt-f8c': double free or corruption (!prev): 0x00000000029b80f0 ***

(In reply to Michael Simacek from comment #3)
> I won't review it now because it doesn't build for me (amd64):
> *** Error in
> `/home/msimacek/rpmbuild/BUILD/fix8-0.9.4/compiler/.libs/lt-f8c': double
> free or corruption (!prev): 0x00000000029b80f0 ***

FYI builds on koji:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=5878120

However this issue has just been reported here...
   https://groups.google.com/forum/#!topic/fix8-developer/FvuCxWd4Cw8

(In reply to David Dight from comment #4)

So will you release 0.9.5 or give us a patch?

I am going to release 0.9.5 next Sunday. I'll send you a patch before then.

(In reply to Christopher Meng from comment #5)
> (In reply to David Dight from comment #4)
> 
> So will you release 0.9.5 or give us a patch?

Released Fix8 0.9.5:

SRPM URL: http://dl.bintray.com/dakka/rpm/fix8-0.9.5-220913.src.rpm

Spec URL: http://cicku.me/fix8.spec
SRPM URL: http://cicku.me/fix8-0.9.5-1.fc21.src.rpm

Is there any technical reason for excluding ARM? If yes, then it should be excluded via %{arm}, not just armv7hl. And what about other arches - ppc or s390 or others?

We are working on an ARMv7 version. Yes, there are technical reasons - with our MPMC queues and use of atomic instructions. For now it made sense to exclude ARM.

0.10.0 out:

Spec URL: http://cicku.me/fix8.spec
SRPM URL: http://cicku.me/fix8-0.10.0-1.fc21.src.rpm

Looks like it bundles the following from boost:

./include/yield.hpp: BSL (v1.0)
./include/coroutine.hpp: BSL (v1.0)

Can the system boost be used instead?

include/ff seems to be "FastFlow"


runtime/gzstream.cpp - LGPLv2+ http://www.cs.unc.edu/Research/compgeom/gzstream/

runtime/modp_numtoa.c - BSD - Nick Galbreath -- nickg [at] modp [dot] com

schema:
# These FIX xml schemas have been sourced from the QuickFix distribution with some minor
# modifications. These schemas are covered by the QuickFIX license below.
#############################################################################################
    
The QuickFIX Software License, Version 1.0
    
Copyright (c) 2001-2010 quickfixengine.org  All rights
reserved.
    
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
    
1. Redistributions of source code must retain the above copyright
   notice, this list of conditions and the following disclaimer.
    
2. Redistributions in binary form must reproduce the above copyright
   notice, this list of conditions and the following disclaimer in
   the documentation and/or other materials provided with the
   distribution.
    
3. The end-user documentation included with the redistribution,
   if any, must include the following acknowledgment:
      "This product includes software developed by
       quickfixengine.org (http://www.quickfixengine.org/)."
   Alternately, this acknowledgment may appear in the software itself,
   if and wherever such third-party acknowledgments normally appear.
    
4. The names "QuickFIX" and "quickfixengine.org" must
   not be used to endorse or promote products derived from this
   software without prior written permission. For written
   permission, please contact ask
  
5. Products derived from this software may not be called "QuickFIX",
   nor may "QuickFIX" appear in their name, without prior written
   permission of quickfixengine.org

The coroutine includes are very small and unlikely to change. It makes sense to include them in the package rather than add another dependency to the project.

Fastflow is included, and is LGPL. Additionally I have express permission from the author to include it in Fix8. gzstream is also LGPL. modp_numtoa is BSD which is a compatible license. The quickfix schemas are included with appropriate attribution and license inclusion.

Are you making some objection to their use/inclusion in the package? Please provide a little more information as to why these were mentioned.

I understand that it makes it easier for your project, but Fedora as a distribution has the following policy:

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

Also, FastFlow seems to grab some other items as well.

Ok understand now.
- I think the schemas would be ok under copylib - in fact the author of quickfix states in their documentation that users are free to copy and use them as they wish.
-gzstream, modp_itoa are all intended to be copied as well, copylib

-boost - we can change to an external dependency in fedora

-fastflow is not in fedora - if the authors do not wish to submit fastflow to fedora does this mean we would have to find an alternative because of the bundling rule?

(In reply to David Dight from comment #15)
> Ok understand now.
> - I think the schemas would be ok under copylib - in fact the author of
> quickfix states in their documentation that users are free to copy and use
> them as they wish.
> -gzstream, modp_itoa are all intended to be copied as well, copylib
> 
> -boost - we can change to an external dependency in fedora
> 
> -fastflow is not in fedora - if the authors do not wish to submit fastflow
> to fedora does this mean we would have to find an alternative because of the
> bundling rule?

Ok.

So I will package fastflow first.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.