Bug 996864
| Summary: | "Unexpected Netty Version was expecting..." warnings during start | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Miroslav Novak <mnovak> |
| Component: | Build, HornetQ | Assignee: | Clebert Suconic <csuconic> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Miroslav Novak <mnovak> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | cdewolf, csuconic, myarboro |
| Target Milestone: | ER6 | Keywords: | Regression |
| Target Release: | EAP 6.1.1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-16 20:26:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miroslav Novak
2013-08-14 08:02:54 UTC
I have recently changed the code to stop using the hash code from Netty at the version verification.
You have now to remove the hash, just keep the pom as original from hornetq'pom:
<!-- don't forget to update netty.version.string manually after updating this. look at the explanation on netty.version.string -->
<netty.version>3.6.6.Final</netty.version>
<!-- please keep netty.version.string literal,
RedHat production team will patch our builds on netty.version..
Our verification for the right Netty version only needs a Netty.getVersion().contains("our-string");
if we make this a variable we will have to rebuild hornetq for any minor rebuild from the production team
and other issues along it.
-->
<netty.version.string>3.6.6.Final</netty.version.string>
if you have to patch it and use the suffix -redhat on the version, keep the netty.version.string as 3.6.6.Final as we should accept any 3.6.6.Final version.
This is just to validate our dependency with Netty, during devel we determined that netty is really important as a dependency for us (it's only one actually), and we were requiring the exact same version during runtime.
@PaulGier: right: I've made this change to avoid such warning in the future. Next step would be to remove this warning check altogether if this still a recurring issue after this. PR from clebert https://github.com/jbossas/jboss-eap/pull/293 Thanks guys! Fixed in EAP 6.1.1.ER6. Verified. |