Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 997798

Summary: Virsh command cpu-baseline cause memory leak.
Product: Red Hat Enterprise Linux 7 Reporter: Peter Krempa <pkrempa>
Component: libvirtAssignee: Peter Krempa <pkrempa>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 7.0CC: acathrow, dyuan, hliu, lsu, mzhan, pkrempa, zsong
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-1.1.1-3.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 997765 Environment:
Last Closed: 2014-06-13 12:27:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 997765    
Bug Blocks:    

Description Peter Krempa 2013-08-16 08:41:04 UTC
+++ This bug was initially created as a clone of Bug #997765 +++

Description of problem:
virsh command cpu-baseline cause memory leak.

Version-Release number of selected component (if applicable):
Red Hat Enterprise Linux Server release 6.5 Beta
libvirt-0.10.2-22.el6.x86_64
kernel-2.6.32-412.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.394.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1. make a cpu profile xml or capabilities xml.
# virsh capabilities > cap.xml

2. check memory leak for cpu-baseline
# valgrind -v --leak-check=full virsh cpu-baseline cap.xml

valgrind result:
==22406== 8 bytes in 1 blocks are definitely lost in loss record 8 of 103
==22406==    at 0x4C2677B: calloc (vg_replace_malloc.c:593)
==22406==    by 0x4E8845B: virAllocN (memory.c:128)
==22406==    by 0x4E9D786: virXPathNodeSet (xml.c:601)
==22406==    by 0x412AAE: cmdCPUBaseline (virsh-domain.c:5298)
==22406==    by 0x40D240: vshCommandRun (virsh.c:1652)
==22406==    by 0x410B4A: main (virsh.c:3093)
==22406==
==22406== LEAK SUMMARY:
==22406==    definitely lost: 8 bytes in 1 blocks
==22406==    indirectly lost: 0 bytes in 0 blocks
==22406==      possibly lost: 0 bytes in 0 blocks
==22406==    still reachable: 139,233 bytes in 1,575 blocks
==22406==         suppressed: 0 bytes in 0 blocks



Expected result:
no memory leak

--- Additional comment from Peter Krempa on 2013-08-16 10:39:31 CEST ---

commit f4ec8616410cea2b7dbe4c535c81cf70162a2939
Author: Peter Krempa <pkrempa>
Date:   Fri Aug 16 10:33:30 2013 +0200

    virsh-domain: Fix memleak in cmdCPUBaseline
    
    https://bugzilla.redhat.com/show_bug.cgi?id=997765
    
    ==1349431== 8 bytes in 1 blocks are definitely lost in loss record 11 of 760
    ==1349431==    at 0x4C2A554: calloc (vg_replace_malloc.c:593)
    ==1349431==    by 0x4E9AA3E: virAllocN (in /usr/lib64/libvirt.so.0.1001.1)
    ==1349431==    by 0x4EF28C4: virXPathNodeSet (in /usr/lib64/libvirt.so.0.1001.1)
    ==1349431==    by 0x130B83: cmdCPUBaseline (in /usr/bin/virsh)
    ==1349431==    by 0x12C608: vshCommandRun (in /usr/bin/virsh)
    ==1349431==    by 0x12889A: main (in /usr/bin/virsh)

Comment 2 Hao Liu 2013-09-02 06:48:27 UTC
Verified this fix.

Packages:
libvirt-client-1.1.1-3.el7.x86_64

Verify steps:
1. make a cpu profile xml or capabilities xml.
# virsh capabilities > cap.xml

2. check memory leak for cpu-baseline
# valgrind -v --leak-check=full virsh cpu-baseline cap.xml

Results:
no memory leak.

Comment 3 Ludek Smid 2014-06-13 12:27:02 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.