Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja-actions.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-actions-1.6.1-1.fc20.src.rpm Description: Caja actions is an extension for Caja, the MATE file manager. It provides an easy way to configure programs to be launch on files selected in Caja interface Fedora Account System Username: raveit65
New sources: Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja-actions.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-actions-1.6.1-2.fc20.src.rpm %changelog * Fri Aug 16 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.1-2 - move doc dirs to a -doc subpackage
Approved! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - update-desktop-database is invoked when required Note: desktop file(s) in caja-actions See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in caja- actions-doc Main package requires -doc [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address) LGPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/leigh/997829-caja- actions/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: The spec file handles locales properly. [x]: Package consistently uses macro is (instead of hard-coded directory names). [?]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [?]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in caja-actions [ ]: Useful -debuginfo package or justification otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2641920 bytes in /usr/share 2641920 caja-actions-1.6.1-2.fc20.x86_64.rpm [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: caja-actions-1.6.1-2.fc20.x86_64.rpm caja-actions-doc-1.6.1-2.fc20.noarch.rpm caja-actions-devel-1.6.1-2.fc20.x86_64.rpm caja-actions.x86_64: W: no-documentation caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-run caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-new caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-print caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-config-tool caja-actions-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/caja-actions/COPYING-DOCS caja-actions-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/caja-actions-doc/COPYING-DOCS caja-actions-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint caja-actions-devel caja-actions-doc caja-actions caja-actions-devel.x86_64: W: no-documentation caja-actions-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/caja-actions/COPYING-DOCS caja-actions-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/caja-actions-doc/COPYING-DOCS caja-actions.x86_64: W: no-documentation caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-run caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-new caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-print caja-actions.x86_64: W: no-manual-page-for-binary caja-actions-config-tool 3 packages and 0 specfiles checked; 0 errors, 8 warnings. # echo 'rpmlint-done:' Requires -------- caja-actions-devel (rpmlib, GLIBC filtered): caja-actions(x86-64) caja-actions-doc (rpmlib, GLIBC filtered): caja-actions (rpmlib, GLIBC filtered): /bin/sh caja-actions-doc libICE.so.6()(64bit) libSM.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcaja-extension.so.1()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libgtop-2.0.so.7()(64bit) libna-core.so()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libunique-1.0.so.0()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) Provides -------- caja-actions-devel: caja-actions-devel caja-actions-devel(x86-64) caja-actions-doc: caja-actions-doc caja-actions: caja-actions caja-actions(x86-64) libcaja-actions-menu.so()(64bit) libcaja-actions-tracker.so()(64bit) libna-core.so()(64bit) libna-io-desktop.so()(64bit) Unversioned so-files -------------------- caja-actions: /usr/lib64/caja-actions/libna-core.so caja-actions: /usr/lib64/caja-actions/libna-io-desktop.so caja-actions: /usr/lib64/caja/extensions-2.0/libcaja-actions-menu.so caja-actions: /usr/lib64/caja/extensions-2.0/libcaja-actions-tracker.so Source checksums ---------------- http://raveit65.fedorapeople.org/Mate/SOURCE/caja-actions-1.6.1.tar.gz : CHECKSUM(SHA256) this package : 9673fe428aec6f1ec0dccb2893bacb3c9cc166aeacb46e02899b7d67844e99dd CHECKSUM(SHA256) upstream package : 9673fe428aec6f1ec0dccb2893bacb3c9cc166aeacb46e02899b7d67844e99dd Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 997829
New Package SCM Request ======================= Package Name: caja-actions Short Description: Caja extension for customizing the context menu Owners: raveit65 Branches: f18 f19 InitialCC:
Git done (by process-git-requests). Please assign the review to the reviewer.
caja-actions-1.6.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/caja-actions-1.6.2-1.fc18
caja-actions-1.6.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/caja-actions-1.6.2-1.fc19
Package caja-actions-1.6.2-1.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing caja-actions-1.6.2-1.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-15019/caja-actions-1.6.2-1.fc19 then log in and leave karma (feedback).
caja-actions-1.6.2-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
caja-actions-1.6.2-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: caja-actions New Branches: f20 Owners: raveit65 InitialCC:
Sorry......for that noise------please ignore
Package Change Request ====================== Package Name: caja-actions New Branches: epel7 Owners: raveit65 InitialCC:
Git done (by process-git-requests).