Bug 998225 - systemd unit file loads wrong environment file
Summary: systemd unit file loads wrong environment file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: smartmontools
Version: 19
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Michal Hlavinka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-18 11:58 UTC by Stefan Hellermann
Modified: 2013-09-24 22:59 UTC (History)
2 users (show)

Fixed In Version: smartmontools-6.2-2.fc18
Clone Of:
Environment:
Last Closed: 2013-09-18 13:06:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch which shows the needed change on an installed system (427 bytes, patch)
2013-08-18 11:58 UTC, Stefan Hellermann
no flags Details | Diff

Description Stefan Hellermann 2013-08-18 11:58:33 UTC
Created attachment 787763 [details]
patch which shows the needed change on an installed system

the systemd unit file loads a wrong environment file:

$ grep EnvironmentFile /usr/lib/systemd/system/smartd.service 
EnvironmentFile=-/etc/smartmontools/sysconfig/smartmontools

$ find / -path "*/sysconfig/smartmontools"
/etc/sysconfig/smartmontools

looks like there is a smartmontools too much in the path to EnvironmentFile in the systemd unit file

Comment 1 Trevor Cordes 2013-08-18 20:16:48 UTC
Yup, someone made a boo-boo:

#rpm -ql smartmontools-6.1-1.fc19.i686 | grep sysconfig
/etc/sysconfig/smartmontools

#grep sysconfig /usr/lib/systemd/system/smartd.service
EnvironmentFile=-/etc/smartmontools/sysconfig/smartmontools

If putting sysconfig stuff in separate per-daemon dirs is the new way of doing things (is it? yuck) then the file in the rpm needs to be moved.  If it's still supposed to be in /etc/sysconfig then the systemd unit file needs to be changed.

Comment 2 Michal Hlavinka 2013-09-16 13:57:56 UTC
Thanks for reporting this.

Comment 3 Fedora Update System 2013-09-16 14:33:02 UTC
smartmontools-6.2-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/smartmontools-6.2-2.fc19

Comment 4 Fedora Update System 2013-09-16 14:33:10 UTC
smartmontools-6.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/smartmontools-6.2-2.fc20

Comment 5 Fedora Update System 2013-09-16 14:34:10 UTC
smartmontools-6.2-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/smartmontools-6.2-2.fc18

Comment 6 Fedora Update System 2013-09-16 16:14:45 UTC
Package smartmontools-6.2-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing smartmontools-6.2-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-16866/smartmontools-6.2-2.fc20
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2013-09-18 13:06:10 UTC
smartmontools-6.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2013-09-24 22:57:41 UTC
smartmontools-6.2-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2013-09-24 22:59:07 UTC
smartmontools-6.2-2.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.