Bug 998322 - javapackages-tools: add_pom_dep_mgmt injects incorrect xml
Summary: javapackages-tools: add_pom_dep_mgmt injects incorrect xml
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: javapackages-tools
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 992306
TreeView+ depends on / blocked
 
Reported: 2013-08-19 03:38 UTC by Matt Spaulding
Modified: 2013-10-10 14:52 UTC (History)
4 users (show)

Fixed In Version: 3.3.1-1
Clone Of:
Environment:
Last Closed: 2013-10-10 14:52:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch against upstream repository to fix add_pom_dep_mgmt macro (620 bytes, patch)
2013-08-19 03:38 UTC, Matt Spaulding
no flags Details | Diff

Description Matt Spaulding 2013-08-19 03:38:52 UTC
Created attachment 787875 [details]
Patch against upstream repository to fix add_pom_dep_mgmt macro

Description of problem:
The add_pom_dep_mgmt macro does not inject the correct xml into the pom file, since it does not include "dependencies" in the xpath when doing the injection.

Version-Release number of selected component (if applicable):
2.0.1-1

How reproducible:
Always

Steps to Reproduce:
1. Use the add_pom_dep_mgmt macro in an RPM spec file.

Actual results:
RPM build will fail since the pom file is incorrect. The "dependency" node is injected right after the "dependencyManagement" node in the pom file.

Expected results:
The dependency gets injected inside the "dependencies" node which is under the "dependencyManagement" node.

Comment 1 Stanislav Ochotnicky 2013-08-19 08:19:21 UTC
Thanks for the patch,  this was indeed a bug. Commited upstream. It might take a while before new realease, but you can workaround this bug by using "pom_xpath_inject" if really needed.

(un?)fortunately add_pom_dep_mgmnt is needed very rarely so it wasn't very well tested.

Comment 2 Fedora End Of Life 2013-09-16 16:56:10 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 3 Mikolaj Izdebski 2013-10-08 18:03:24 UTC
Fixed in javapackages-tools-3.3.1-1

Comment 4 Mikolaj Izdebski 2013-10-10 14:52:02 UTC
I believe that this bug is fixed in javapackages-tools-3.3.1-1,
which is available in Fedora 20, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=469209


Note You need to log in before you can comment on or make changes to this bug.