Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-perl5i/branches/fedora/perl-perl5i.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-perl5i/perl-perl5i-2.12.0-2.fc20.src.rpm Description: Perl 5 has a lot of warts. There's a lot of individual modules and techniques out there to fix those warts. perl5i aims to pull the best of them together into one module so you can turn them on all at once. This includes adding features, changing existing core functions and changing defaults. It will likely not be 100% backwards compatible with Perl 5, though it will be 99%, perl5i will try to have a lexical effect. Please add to this imaginary world and help make it real, either by telling me what Perl looks like in your imagination (http://github.com/schwern/perl5i/issues) or make a fork (forking on github is like a branch you control) and implement it yourself. Fedora Account System Username: pghmcfc
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: perl-perl5i (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [!]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. $ rpmlint ./perl-perl5i.spec ../results/perl-perl5i-2.12.0-2.fc21.* perl-perl5i.src: W: spelling-error Summary(en_US) pragma -> pragmatic perl-perl5i.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish perl-perl5i.x86_64: W: spelling-error Summary(en_US) pragma -> pragmatic perl-perl5i.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint ok $ rpm -qp --provides ../results/perl-perl5i-2.12.0-2.fc21.x86_64.rpm | sort | uniq -c 1 perl(perl5i) 1 perl(perl5i::0) 1 perl(perl5i::0::ARRAY) 1 perl(perl5i::0::DEFAULT) 1 perl(perl5i::0::DateTime) 1 perl(perl5i::0::DateTime::Format::CTime) 1 perl(perl5i::0::DateTime::time) 1 perl(perl5i::0::DateTime::y2038) 1 perl(perl5i::0::HASH) 1 perl(perl5i::0::Meta) 1 perl(perl5i::0::Meta::Class) 1 perl(perl5i::0::Meta::Instance) 1 perl(perl5i::0::SCALAR) 1 perl(perl5i::1) 1 perl(perl5i::1::ARRAY) 1 perl(perl5i::1::CODE) 1 perl(perl5i::1::DateTime) 1 perl(perl5i::1::DateTime::Format::CTime) 1 perl(perl5i::1::DateTime::time) 1 perl(perl5i::1::DateTime::y2038) 1 perl(perl5i::1::HASH) 1 perl(perl5i::1::Meta) 1 perl(perl5i::1::Meta::Class) 1 perl(perl5i::1::Meta::Instance) 1 perl(perl5i::1::SCALAR) 1 perl(perl5i::1::UNIVERSAL) 1 perl(perl5i::1::autobox) 1 perl(perl5i::2) 1 perl(perl5i::2::ARRAY) 1 perl(perl5i::2::CODE) 1 perl(perl5i::2::DateTime) 1 perl(perl5i::2::DateTime::Format::CTime) 1 perl(perl5i::2::DateTime::time) 1 perl(perl5i::2::DateTime::y2038) 1 perl(perl5i::2::HASH) 1 perl(perl5i::2::Meta) 1 perl(perl5i::2::Meta::Class) 1 perl(perl5i::2::Meta::Instance) 1 perl(perl5i::2::RequireMessage) 1 perl(perl5i::2::SCALAR) 1 perl(perl5i::2::Signature) 1 perl(perl5i::2::Signature::Function::None) 1 perl(perl5i::2::Signature::Method::None) 1 perl(perl5i::2::Signature::None) 1 perl(perl5i::2::Signature::Real) 1 perl(perl5i::2::Signatures) 1 perl(perl5i::2::UNIVERSAL) 1 perl(perl5i::2::autobox) 1 perl(perl5i::2::equal) 1 perl(perl5i::VERSION) 1 perl(perl5i::cmd) 1 perl(perl5i::latest) 1 perl-perl5i = 2.12.0-2.fc21 1 perl-perl5i(x86-64) = 2.12.0-2.fc21 Binary provides ok $ rpm -qp --requires ../results/perl-perl5i-2.12.0-2.fc21.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libgcc_s.so.1()(64bit) 1 libgcc_s.so.1(GCC_3.0)(64bit) 1 libgcc_s.so.1(GCC_3.3.1)(64bit) 1 perl >= 1:5.010 1 perl >= 1:5.010_000 1 perl(:MODULE_COMPAT_5.18.1) 1 perl(CLASS) >= 1.00 1 perl(Capture::Tiny) >= 0.06 1 perl(Carp) 1 perl(Carp::Fix::1_25) >= 1.000000 1 perl(Child) >= 0.009 1 perl(DateTime) >= 0.47 1 perl(DateTime::Format::Epoch) >= 0.11 1 perl(DateTime::TimeZone::Tzfile) >= 0.002 1 perl(Devel::Declare::MethodInstaller::Simple) >= 0.006009 1 perl(Digest::MD5) >= 2.36 1 perl(Digest::SHA) >= 5.45 1 perl(Encode) 1 perl(File::chdir) >= 0.1002 1 perl(Hash::FieldHash) >= 0.06 1 perl(Hash::Merge::Simple) >= 0.04 1 perl(Hash::StoredIterator) >= 0.005 1 perl(IO::Handle) 1 perl(IPC::System::Simple) >= 1.18 1 perl(JSON) >= 2.17 1 perl(List::MoreUtils) >= 0.22 1 perl(Modern::Perl) >= 1.03 1 perl(Module::Load) >= 0.16 1 perl(Object::ID) >= v0.1.0 1 perl(POSIX) 1 perl(Perl6::Caller) >= 0.100 1 perl(Scalar::Util) 1 perl(Sub::Name) 1 perl(Taint::Util) >= 0.06 1 perl(Text::Wrap) >= 2009.0305 1 perl(Time::y2038) 1 perl(Try::Tiny) >= 0.02 1 perl(Want) >= 0.18 1 perl(YAML::Any) >= 0.70 1 perl(autobox) >= 2.70 1 perl(autobox::Core) >= 1.0 1 perl(autobox::List::Util) >= 20090629 1 perl(autobox::dump) >= 20090426 1 perl(autodie) >= 2.12 1 perl(autovivification) >= 0.06 1 perl(base) 1 perl(constant) 1 perl(indirect) >= 0.24 1 perl(mro) 1 perl(open) 1 perl(overload) 1 perl(parent) >= 0.221 1 perl(perl5i::0::ARRAY) 1 perl(perl5i::0::DEFAULT) 1 perl(perl5i::0::DateTime) 1 perl(perl5i::0::HASH) 1 perl(perl5i::0::Meta) 1 perl(perl5i::0::Meta::Class) 1 perl(perl5i::0::Meta::Instance) 1 perl(perl5i::0::SCALAR) 1 perl(perl5i::1::ARRAY) 1 perl(perl5i::1::CODE) 1 perl(perl5i::1::DateTime) 1 perl(perl5i::1::HASH) 1 perl(perl5i::1::Meta) 1 perl(perl5i::1::Meta::Class) 1 perl(perl5i::1::Meta::Instance) 1 perl(perl5i::1::SCALAR) 1 perl(perl5i::1::UNIVERSAL) 1 perl(perl5i::1::autobox) 1 perl(perl5i::2) 1 perl(perl5i::2::ARRAY) 1 perl(perl5i::2::CODE) 1 perl(perl5i::2::HASH) 1 perl(perl5i::2::Meta) 1 perl(perl5i::2::Meta::Class) 1 perl(perl5i::2::Meta::Instance) 1 perl(perl5i::2::RequireMessage) 1 perl(perl5i::2::SCALAR) 1 perl(perl5i::2::Signature) 1 perl(perl5i::2::Signature::Function::None) 1 perl(perl5i::2::Signature::Method::None) 1 perl(perl5i::2::Signature::None) 1 perl(perl5i::2::Signatures) 1 perl(perl5i::2::UNIVERSAL) 1 perl(perl5i::2::autobox) 1 perl(perl5i::VERSION) 1 perl(perl5i::latest) 1 perl(strict) 1 perl(true::VERSION) >= 0.16 1 perl(utf8) 1 perl(utf8::all) >= 0.002 1 perl(version) >= 0.77 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires ok Source checksums ---------------- http://cpan.metacpan.org/authors/id/M/MS/MSCHWERN/perl5i-v2.12.0.tar.gz : CHECKSUM(SHA256) this package : 93c92ec501ec3b19592f11c97a2e2872b01e58dfd526bd49a18e9e8ba620a410 CHECKSUM(SHA256) upstream package : 93c92ec501ec3b19592f11c97a2e2872b01e58dfd526bd49a18e9e8ba620a410 ISSUES: FIX: Add BRs: perl(Carp), perl(Config), perl(Data::Dumper), perl(Encode), perl(Exporter), perl(File::Spec), perl(File::Temp), perl(if), perl(IO::Handle), perl(lib), perl(PerlIO), perl(POSIX), perl(Scalar::Util), perl(Sub::Name) FIX: Add Requires: perl(File::Spec) (./lib/perl5i/2/SCALAR.pm) Otherwise package looks good. APPROVED.
Fixed in -3: Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-perl5i/branches/fedora/perl-perl5i.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-perl5i/perl-perl5i-2.12.0-3.fc21.src.rpm
New Package SCM Request ======================= Package Name: perl-perl5i Short Description: Fix as much of Perl 5 as possible in one pragma Owners: pghmcfc Branches: f19 f20 InitialCC: perl-sig Thanks for the review again Jitka.
Git done (by process-git-requests).
perl-perl5i-2.12.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-perl5i-2.12.0-3.fc20
perl-perl5i-2.12.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-perl5i-2.12.0-3.fc19
perl-perl5i-2.12.0-3.fc19 has been pushed to the Fedora 19 stable repository.
perl-perl5i-2.12.0-3.fc20 has been pushed to the Fedora 20 stable repository.