Spec URL: http://oirase.annexia.org/reviews/qemu-sanity-check/qemu-sanity-check.spec SRPM URL: http://oirase.annexia.org/reviews/qemu-sanity-check/qemu-sanity-check-1.1.1-1.fc19.src.rpm Description: Qemu-sanity-check is a short shell script that test-boots a Linux kernel under qemu, making sure it boots up to userspace. The idea is to test the Linux kernel and/or qemu to make sure they are working. Fedora Account System Username: rjones
rpmlint says: qemu-sanity-check.src: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace qemu-sanity-check.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace qemu-sanity-check.x86_64: E: no-binary qemu-sanity-check.x86_64: W: only-non-binary-in-usr-lib Ignore the "spelling errors". I believe the no-binary and only-non-binary-in-usr-lib are erroneous. See bug 999105.
Spec URL: http://oirase.annexia.org/reviews/qemu-sanity-check/qemu-sanity-check.spec SRPM URL: http://oirase.annexia.org/reviews/qemu-sanity-check/qemu-sanity-check-1.1.2-1.fc19.src.rpm Description: Qemu-sanity-check is a short shell script that test-boots a Linux kernel under qemu, making sure it boots up to userspace. The idea is to test the Linux kernel and/or qemu to make sure they are working. [This time with the bugs fixed ...]
Successful Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5834503
Just curious about kernel, do we need to add BR/R of it? Thanks.
There is already the right requirements on kernel. When you add yourself to the CC, please don't remove other random users from the CC.
Spec URL: http://oirase.annexia.org/reviews/qemu-sanity-check/qemu-sanity-check.spec SRPM URL: http://oirase.annexia.org/reviews/qemu-sanity-check/qemu-sanity-check-1.1.2-2.fc19.src.rpm Updated to split the package into an ordinary qemu-sanity-check package and a qemu-sanity-check-nodeps subpackage that doesn't have dependencies on qemu/kernel. This allows qemu & kernel to use the -nodeps package so they don't end up with circular BuildRequires. Note the tarball in that .src.rpm doesn't match the tarball on the website (because of the updated spec file in the tarball).
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/mbooth/tmp/999108-qemu- sanity-check/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: cpio See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qemu- sanity-check-nodeps [ ]: Package complies to the Packaging Guidelines [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)". Detailed output of licensecheck in /home/mbooth/tmp/999108-qemu-sanity-check/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qemu-sanity-check-1.1.2-2.fc19.x86_64.rpm qemu-sanity-check-nodeps-1.1.2-2.fc19.x86_64.rpm qemu-sanity-check.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace qemu-sanity-check.x86_64: W: spelling-error %description -l en_US nodeps -> nodes, node's qemu-sanity-check.x86_64: E: no-binary qemu-sanity-check-nodeps.x86_64: W: spelling-error %description -l en_US depedencies -> dependencies, expediencies, presidencies qemu-sanity-check-nodeps.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint qemu-sanity-check qemu-sanity-check-nodeps qemu-sanity-check.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace qemu-sanity-check.x86_64: W: spelling-error %description -l en_US nodeps -> nodes, node's qemu-sanity-check.x86_64: E: no-binary qemu-sanity-check-nodeps.x86_64: W: spelling-error %description -l en_US depedencies -> dependencies, expediencies, presidencies qemu-sanity-check-nodeps.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- qemu-sanity-check (rpmlib, GLIBC filtered): kernel qemu-sanity-check-nodeps qemu-system-x86 qemu-sanity-check-nodeps (rpmlib, GLIBC filtered): /bin/bash Provides -------- qemu-sanity-check: qemu-sanity-check qemu-sanity-check(x86-64) qemu-sanity-check-nodeps: qemu-sanity-check-nodeps qemu-sanity-check-nodeps(x86-64) Source checksums ---------------- http://people.redhat.com/~rjones/qemu-sanity-check/files/qemu-sanity-check-1.1.2.tar.gz : CHECKSUM(SHA256) this package : 002f661b1c42a97c4c28a678f619cbbd2568ad45a77c34312a9d67dd5f553642 CHECKSUM(SHA256) upstream package : 5d427d01f6c5da7bcc898438099976f3638d99bce47b8b9e703f5880de71e234 diff -r also reports differences Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-19-x86_64 Command line :/usr/bin/fedora-review -b 999108
This all looks good. The only strangeness is the -nodeps package. This is justified in the spec file comments as a workaround to avoid a circular dependency if the tool is a BuildRequires of qemu or kernel.
New Package SCM Request ======================= Package Name: qemu-sanity-check Short Description: Simple qemu and Linux kernel sanity checker Branches: f19 f20 InitialCC:
No FAS accounts listed.
New Package SCM Request ======================= Package Name: qemu-sanity-check Short Description: Simple qemu and Linux kernel sanity checker Owners: rjones Branches: f19 f20 InitialCC: Don't know what happened there .. possibly a cut and paste error.
Git done (by process-git-requests).
qemu-sanity-check-1.1.3-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qemu-sanity-check-1.1.3-4.fc19
qemu-sanity-check-1.1.3-4.fc19 has been pushed to the Fedora 19 testing repository.
qemu-sanity-check-1.1.4-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qemu-sanity-check-1.1.4-2.fc19
qemu-sanity-check-1.1.4-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.