Bug 999232 - "pre_start" commit hook not called as part of a restart operation
"pre_start" commit hook not called as part of a restart operation
Product: OpenShift Online
Classification: Red Hat
Component: Containers (Show other bugs)
All All
unspecified Severity medium
: ---
: ---
Assigned To: Jhon Honce
libra bugs
Depends On:
  Show dependency treegraph
Reported: 2013-08-20 21:01 EDT by Andrew Lee Rubinger
Modified: 2013-08-21 10:53 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-08-21 10:53:16 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Andrew Lee Rubinger 2013-08-20 21:01:37 EDT
Description of problem:

pre_start action hook is not called on "ctl_app restart" or other restart methods.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Create an executable action hook in .openshift/action_hooks/pre_start_jbosseap (for instance for the EAP cartridge)
2. Put an echo statement in the pre_start action hook
3. Start the server, observe the echo statement
4. Restart the server, either via the Web UI or via SSH to "ctl_app restart".  Observe no echo statement from the action hook

Actual results:

pre_start action hook is not called on restart.

Expected results:

I would expect "restart" to be a composition of "stop" plus "start", not a separate lifecycle event.

Note line 19 of the following pastebin, which is not observed on restart but is on manual stop/start cycle:  http://pastebin.com/HMs134rP
Comment 1 Jhon Honce 2013-08-21 10:53:16 EDT
The pre_restart hook is called.  If you wish to re-use your pre_start script you should call it from the pre_restart hook.

The reason for this is restart is not always stop/start in all cartridges.

Note You need to log in before you can comment on or make changes to this bug.