Description of problem: 'loan settings' not work on edit system page Version-Release number of selected component (if applicable): beaker-devel Version - 0.14.1 How reproducible: always Steps to Reproduce: 1. visit system page, and click 'edit system'. 2. then click 'loan settings'. 3. input user in 'Loan To' and click button 'update loan'. Actual results: no response. Expected results: the feature should work as on *view* system page. Additional info:
This problem still exists in 0.15 An acceptable alternative to making it work would be to simply hide the non-functional controls when in the edit view.
Including this with the other loan UI cleanups planned for 0.15.1
Normally the problem in this situation, is that the widget is not being returned directly in the controller, or is not a member widget of a widget that is. That explains why it doesn't work in the 'edit' page. It does not explain why it does work in the regular page. It turns out that by some stroke of magic the LoanWidget's resources are being added to the TaskSearchForm widget instance, which is being returned at the top level of the relevant controller method. Ignoring that though, the solution here I think is just to return the LoanWidget instance from the controller as well.
Actually no, the correct solution is to make LoanWidget a member widget of SystemForm.
http://gerrit.beaker-project.org/#/c/2404/
Do we need to show the loan widget at all on the edit page?
Not necessarily. My only reservation is having some widgets mysteriously removed and others not, and for no other reason other than that's what we decided to do (and then have people raise bugs because they don't know any better) I'd be more happy with removing all widgets that are not directly related to editing a system, or keeping them all.
This has been fixed as part of the system page redesign (bug 1014438). https://beaker-project.org/dev/proposals/system-page-improvements.html
Beaker 19.0 has been released.