Hide Forgot
Description of problem: On instance, "oo-admin-ctl-tc startuser $gear_uuid" does not check whether "tc" is started before the command is executed. If it is already started, failure result will return. Version-Release number of selected component (if applicable): devenv_stage_448 How reproducible: always Steps to Reproduce: 1. On instance, oo-admin-ctl-tc startuser $gear_uuid 2. Once again, oo-admin-ctl-tc startuser $gear_uuid 3. Actual results: [root@ip-10-116-85-9 status]# oo-admin-ctl-tc startuser 607875093880208780951552 Starting tc for 607875093880208780951552: throttled [OK] [root@ip-10-116-85-9 status]# oo-admin-ctl-tc startuser 607875093880208780951552 Starting tc for 607875093880208780951552: throttled [FAIL] RTNETLINK answers: File exists Command failed (null):1 RTNETLINK answers: File exists Command failed (null):2 RTNETLINK answers: File exists Command failed (null):3 RTNETLINK answers: File exists Command failed (null):4 [root@ip-10-116-85-9 status]# Expected results: If tc is already started, no failures like above should be given. Additional info:
This is a tricky one, because I can't figure out how to check if the 'tc' command already include the rules for user... Probably one solution would be to check if the error message is 'File exists' and suppress that.
Forget what I said ;-) Just found 'statususer' ;-)
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/e4ceb5d5d6576934359f9fb359be84df8ea7f458 Bug 999884 - Check if 'tc' already exists in oo-admin-ctl-tc
Tested on devenv_4030. [root@ip-10-118-161-73 ~]# oo-admin-ctl-tc startuser 5284329eebbbddef86000007 Starting tc for 5284329eebbbddef86000007: Throttling is already active for 5284329eebbbddef86000007 [OK] [root@ip-10-118-161-73 ~]# oo-admin-ctl-tc startuser 5284329eebbbddef86000007 Starting tc for 5284329eebbbddef86000007: Throttling is already active for 5284329eebbbddef86000007 [OK] It looks much better than before, although it always shows the same message whenever doing "oo-admin-ctl-tc startuser". Mark the bug as verified.