Bug 1202890 (kaccounts-providers) - Review Request: kaccounts-providers - Additional service providers for KAccounts framework
Summary: Review Request: kaccounts-providers - Additional service providers for KAccou...
Keywords:
Status: CLOSED RAWHIDE
Alias: kaccounts-providers
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: signon-ui
Blocks: kde-reviews ktp-kf5
TreeView+ depends on / blocked
 
Reported: 2015-03-17 15:57 UTC by Daniel Vrátil
Modified: 2015-11-02 01:38 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-31 11:05:52 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Vrátil 2015-03-17 15:57:20 UTC
Spec URL: https://dvratil.fedorapeople.org/spec/kaccounts-providers.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/kaccounts-providers-15.03.90-1.fc21.src.rpm
Description: Additional service providers for KAccounts framework
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2015-03-25 09:45:21 UTC
rpmlint
-------
kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/api.twitter.com.conf
kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/identi.ca.conf
kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/accounts.google.com.conf
kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/www.facebook.com.conf
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

1) I think you should mark the files installed to /etc as config files with %config

Comment 2 Daniel Vrátil 2015-03-25 09:49:36 UTC
Spec URL: https://dvratil.fedorapeople.org/spec/kaccounts-providers.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/kaccounts-providers-15.03.90-2.fc21.src.rpm

* Wed Mar 25 2015 Daniel Vrátil <dvratil> - 15.03.90-2
- use %%config
- use %%license instead of %%doc

Comment 3 Jan Grulich 2015-03-25 09:57:08 UTC
One minor issue spotted, license should be GPLv2 (at least COPYING says so), but this could be fixed during import. APPROVED.

Comment 4 Daniel Vrátil 2015-03-25 14:22:26 UTC
New Package SCM Request
=======================
Package Name: kaccounts-providers
Short Description: Additional service providers for KAccounts framework
Upstream URL: https://projects.kde.org/projects/kde/kdenetwork/kaccounts-providers
Owners: group::kde-sig
Branches: f22
InitialCC:

Comment 5 Gwyn Ciesla 2015-03-25 17:27:40 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.