SRPM URL: http://home.comcast.net/~ckweyl/libssh2-0.18-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/libssh2.spec Description: libssh2 is a library implementing the SSH2 protocol as defined by Internet Drafts: SECSH-TRANS(22), SECSH-USERAUTH(25), SECSH-CONNECTION(23), SECSH-ARCH(20), SECSH-FILEXFER(06)*, SECSH-DHGEX(04), and SECSH-NUMBERS(10).
One more thing to update in the post-to-review script... :) SRPM URL: http://fedora.biggerontheinside.net/review/libssh2-0.18-2.fc6.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/libssh2.spec
*** Bug 239279 has been marked as a duplicate of this bug. ***
For 0.18-2: * %check - This tarball contains tests/ directory and "make check" seems to execute some test programs. Please create %check section and do some tests in there if possible. * Timestamps - Please add --------------------------------------------------- INSTALL="install -p" --------------------------------------------------- to "make install". While sometimes this does not do anything, usually this method works for keeping timestamps on installed files for recent Makefiles.
Updated: SRPM URL: http://fedora.biggerontheinside.net/review/libssh2-0.18-3.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/libssh2.spec
Well, what I meant is to add 'INSTALL="install -p"' to the option of "make install", i.e. ------------------------------------------------------------ make install DESTDIR=%{buildroot} INSTALL="install -p" ------------------------------------------------------------ Other things are okay. -------------------------------------------------------- This package (libssh2) is APPROVED by me --------------------------------------------------------
(In reply to comment #5) > Well, what I meant is to add 'INSTALL="install -p"' to the option > of "make install", i.e. > > ------------------------------------------------------------ > make install DESTDIR=%{buildroot} INSTALL="install -p" > ------------------------------------------------------------ Gotcha -- changed. :)
New Package CVS Request ======================= Package Name: libssh2 Short Description: A library implementing the SSH2 protocol Owners: cweyl Branches: F-7, F-8, devel InitialCC:
cvs done
Imported and building. Thanks for the review! :)
scratch that :)
Package Change Request ====================== Package Name: libssh2 New Branches: EL-4 EL-5 Updated Fedora CC: djuran Updated EPEL Owners: djuran As discussed with Chris over email, I will take ownership of EPEL branches for this package
hello. also is possible to packge php-pecl-ssh2 ? http://pecl.php.net/package/ssh2
(In reply to comment #13) > hello. > > also is possible to packge php-pecl-ssh2 ? > http://pecl.php.net/package/ssh2 Please submit another review request. Perhaps someone who knows about php much more than me will review it.
cvs done.