Bug 863768 (mate-display-manager) - Review Request: mate-display-manager - Displays login screen for MATE Desktop
Summary: Review Request: mate-display-manager - Displays login screen for MATE Desktop
Keywords:
Status: CLOSED CANTFIX
Alias: mate-display-manager
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: MATE-DE-tracker
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-10-07 10:23 UTC by Dan Mashal
Modified: 2012-10-30 09:47 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-10-30 09:47:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dan Mashal 2012-10-07 10:23:58 UTC
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-display-manager.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-display-manager-1.4.0-1.fc17.src.rpm
Description: MATE Desktop display manager

successful scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=4568160

NOTE: THIS PACKAGE IS A STRAIGHT UP HACK. BUT IT WORKS.
NOTE2: I got this straight from Perberos (creator of MATE). This is not available upstream.

This package enables MATE to display a login screen without piggy backing on GDM, KDM or LXDM.

Comment 1 Michael S. 2012-10-07 13:09:16 UTC
Since the sourceurl is hosted on your fedorapeople account and you say this is not upstream, I assume there is no official tarball yet, and so this was generated straight from git.

I think the guideline ask for adding a comment on where the and how the source code was generated.

https://fedoraproject.org/wiki/Packaging:SourceURL

( ie "saying this was given by someone" is not a proper way to document it )

Comment 2 Dan Mashal 2012-10-07 18:14:59 UTC
This came from upstream. Do you want IRC logs? How would I prove it? Have you tried testing it?

Comment 3 Rex Dieter 2012-10-07 20:05:50 UTC
including a log of the conversation would help

Comment 4 Dan Mashal 2012-10-07 21:56:12 UTC
informational links:

https://wiki.archlinux.org/index.php/MATE#MATE_Display_Manager

http://forums.mate-desktop.org/viewtopic.php?f=5&t=125

http://forums.mate-desktop.org/viewtopic.php?f=2&t=476

Will create an attachment with irc conversation logs in a bit.

Comment 5 Wolfgang Ulbrich 2012-10-07 22:41:58 UTC
Sorry, there is no current official upstream source of mate-display-manager.
All releases are under http://pub.mate-desktop.org/releases/
You will find any git source under https://github.com/mate-desktop .
For your information mate-display-manager is droped since 1.4 release.
LinuxMint provide MDM, but this is a fork from gdm-2.20 and complete different.

best regards

Comment 6 Michael S. 2012-10-07 23:05:03 UTC
The main point of this guideline is to make sure we can reproduce the tarball if this was not published by upstream as such, either for auditing reason or to upgrade it. IE, the goal is to avoid having a bus factor of 1. 

So attaching irc logs or giving link to forums doesn't really fullfill this requirement. 

Either upstream publish it properly, or if they do not want because they consider this is not ready, then it should be marked as pre release software (  http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages ), and we should have a way to not what git rev is used, and how was the tarball created.

Comment 7 Jens Petersen 2012-10-10 02:07:35 UTC
Sure it would be good and preferred if there was a well-defined upstream
and official release for this package.  Unfortunately it seems not to be
the case right now.

I think if comments could be added to spec file explaining the situation
and origin of the source tarball, then this could not block the review
of this package per se?

Comment 8 Dan Mashal 2012-10-10 18:39:23 UTC
Holding off on this. Might use lightdm or mdm instead.


Note You need to log in before you can comment on or make changes to this bug.