Spec URL: http://fedorapeople.org/~cweyl/review/perl-Jemplate.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Jemplate-0.23-1.fc10.src.rpm Description: Jemplate is a templating framework for JavaScript that is built over Perl's Template Toolkit (TT2). Jemplate parses TT2 templates using the TT2 Perl framework, but with a twist. Instead of compiling the templates into Perl code, it compiles them into JavaScript. Jemplate then provides a JavaScript runtime module for processing the template code. Presto, we have full featured JavaScript templating language! Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1257482 *rt-0.05
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1257482 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 208799c450df16134949ee031b92eef4 Jemplate-0.23.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=20, Tests=140, 22 wallclock secs ( 0.12 usr 0.02 sys + 9.59 cusr 0.71 csys = 10.44 CPU) + Package perl-Jemplate-0.23-1.fc11.noarch => Provides: perl(Jemplate) = 0.23 perl(Jemplate::Directive) perl(Jemplate::Grammar) = 2.10 perl(Jemplate::Parser) perl(Jemplate::Runtime) perl(Jemplate::Runtime::Compact) Requires: /usr/bin/perl perl >= 0:5.004 perl >= 0:5.006001 perl(Getopt::Long) perl(Jemplate) >= 0.22 perl(Jemplate::Directive) perl(Jemplate::Grammar) perl(Jemplate::Parser) perl(Template) >= 2.14 perl(base) perl(lib) perl(strict) perl(vars) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Jemplate Short Description: JavaScript Templating with Template Toolkit Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)