SRPM URL: http://fedora.biggerontheinside.net/review/perl-Template-Timer-0.04-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Template-Timer.spec Description: Template::Timer provides inline timings of the template processing througout your code. It's an overridden version of Template::Context that wraps the process() and include() methods.
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=520534
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=520534 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 063b7d84c5cd501a2820f9c2e601eadc Template-Timer-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=4, 0 wallclock secs ( 0.37 cusr + 0.02 csys = 0.39 CPU) + Package perl-Template-Timer-0.04-1.fc9 => Provides: perl(Template::Timer) = 0.04 Requires: perl(Time::HiRes) perl(base) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Template-Timer Short Description: Template::Timer Perl module Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Thanks for the review!
Package Change Request ====================== Package Name: perl-Template-Timer New Branches: el6 Owners: iarnell tremble
Git done (by process-git-requests).