Bug 1000078

Summary:	Review Request: dmcache-utils - Utilities to simplify the usage of dm-cache devices
Product:	[Fedora] Fedora	Reporter:	Rolf Fokkens <rolf>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DEFERRED	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	i, notting, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	NotReady
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-27 10:48:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	998543, 1008227, 1008228

Description Rolf Fokkens 2013-08-22 15:39:14 UTC

Spec URL: http://bdsync.rolf-fokkens.nl/dmcache-utils-20130822/dmcache-utils.spec
SRPM URL: http://bdsync.rolf-fokkens.nl/dmcache-utils-20130822/dmcache-utils-0-0.1.20130822git.fc19.src.rpm
Description:

This package provides a few simple scripts to simplify the usage of
dm-cache devices.
dm-cache is a device mapper target that aims to improve performance
of a block device (e.g., a spindle) by dynamically migrating some of
its data to a faster, smaller device (e.g., an SSD).

http://koji.fedoraproject.org/koji/taskinfo?taskID=5841931

This is my second package, I'm looking for a sponsor.
Fedora Account System Username: rolffokkens

Comment 1 Rolf Fokkens 2013-08-22 15:49:35 UTC

Upstream informed: https://github.com/opinsys/dmcache-utils/issues/1

Comment 2 Zbigniew Jędrzejewski-Szmek 2013-08-22 21:48:26 UTC

Can't sponsor you, but I can review the package:

Hm, actually looking at the scripts, I'm pretty sure that they shouldn't be packaged for Fedora, at least as is. They might work for simple cases, but those scripts are quite brute force: dmc-load will be run when any block device is inserted, so e.g. inserting a USB stick might cause actions to be performed. 
I'm not sure what is the proper way to do this, but it certainly doesn't seem right. Probably the example of LVM should be followed, to perform setup only for the device that was just plugged in.

In case you want to continue packaging in some form:

Source: please define global %gitcommit and use https://github.com/opinsys/dmcache-utils/archive/%{gitcommit}.tar.gz.
Then %setup can use -n %{name}-%{gitcommit}.

%description should say what the scripts actually do ("simplify the usage"
is too generic).

License should be GPLv2+, not GPLv2.

Comment 3 Rolf Fokkens 2013-08-23 12:58:31 UTC

Thanks for your feedback.

Built the package in a hurry because of the F20 dev deadline, but I'm somewhat in doubt on how to proceed. I'm not sure now if the package should exist, because dm-cache can also be used without the scripts.

Comment 4 Rolf Fokkens 2013-08-27 06:27:48 UTC

Sent this message to the dm-devel mail list:

https://www.redhat.com/archives/dm-devel/2013-August/msg00134.html

No response yet, awaiting any response to sense the "Fedora readiness"

Comment 5 Rolf Fokkens 2013-08-27 10:48:32 UTC

Sounds like we should wait for LVM2 to support the caching:

https://www.redhat.com/archives/dm-devel/2013-August/msg00137.html

I'll close this one for now; F20 doesn't look feasible.

Comment 6 Christopher Meng 2013-08-27 10:52:55 UTC

You can reopen and mark it as not ready.

Comment 7 Rolf Fokkens 2013-08-27 10:54:54 UTC

Will do so in the future.