| Summary: | Review Request: nini - An uncommonly powerful .NET configuration library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | claudiorodrigo, i, notting, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nini-1.1.0-2.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-14 03:01:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Christopher Meng
2013-08-26 02:22:27 UTC
1. Package is noarch, so the -devel should not require %{name}%{?_isa}, just plain %{name}.
2. %description should be a bit more informative about what the library does, and should not repeat the blurb "uncommonly powerful" which doesn't really mean much.
3. The contents of the "Docs" directory could be moved one level up (so there would be /usr/share/doc/nini/Reference/, /usr/share/doc/nini/Manual).
- License is OK
- package name is OK
- spec is nice and clear
- sources are downloadable and match the srpm
- dist tag is there
- no build root or other obsolete stuff
- license is ok, file present and installed
- latest version
- follows Mono guidelines
- %files is OK
rpmlint nini:
nini.src:37: E: hardcoded-library-path in %{_prefix}/lib/nini
nini.src:39: E: hardcoded-library-path in %{_prefix}/lib/nini/
nini.src:46: E: hardcoded-library-path in %{_prefix}/lib/nini/
It's OK per mono guidelines.
nini.src:41: W: macro-in-comment %{name}
nini.src:41: W: macro-in-comment %{buildroot}
nini.src:41: W: macro-in-comment %{_prefix}
That comment could be removed.
nini.src: W: invalid-url Source0: http://downloads.sourceforge.net/project/nini/Nini/1.1.0/Nini-1.1.0.zip timed out
Works for me.
% rpmlint nini-devel
nini-devel.noarch: W: no-documentation
nini-devel.noarch: W: spurious-executable-perm /usr/share/pkgconfig/nini.pc
${SOURCE1} should be -x.
Nice and clean module issues noted above.
Package is APPROVED.
New Package SCM Request ======================= Package Name: nini Short Description: An uncommonly powerful .NET configuration library Owners: cicku Branches: f20 Git done (by process-git-requests). nini-1.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nini-1.1.0-1.fc20 nini-1.1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nini-1.1.0-2.fc20 *** Bug 605840 has been marked as a duplicate of this bug. *** *** Bug 759139 has been marked as a duplicate of this bug. *** nini-1.1.0-1.fc20 has been pushed to the Fedora 20 testing repository. nini-1.1.0-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |