Bug 1000870 - Review Request: nini - An uncommonly powerful .NET configuration library
Summary: Review Request: nini - An uncommonly powerful .NET configuration library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 605840 759139 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-26 02:22 UTC by Christopher Meng
Modified: 2013-12-14 03:01 UTC (History)
5 users (show)

Fixed In Version: nini-1.1.0-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-14 03:01:02 UTC
Type: ---
zbyszek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Christopher Meng 2013-08-26 02:22:27 UTC
Spec URL: http://cicku.me/nini.spec
SRPM URL: http://cicku.me/nini-1.1.0-1.fc21.src.rpm 
Description: Nini is an uncommonly powerful .NET configuration library designed to help 
build highly configurable applications quickly.
Fedora Account System Username: cicku

Comment 1 Zbigniew Jędrzejewski-Szmek 2013-11-10 21:58:05 UTC
1. Package is noarch, so the -devel should not require %{name}%{?_isa}, just plain %{name}.

2. %description should be a bit more informative about what the library does, and should not repeat the blurb "uncommonly powerful" which doesn't really mean much.

3. The contents of the "Docs" directory could be moved one level up (so there would be /usr/share/doc/nini/Reference/, /usr/share/doc/nini/Manual).

- License is OK
- package name is OK
- spec is nice and clear
- sources are downloadable and match the srpm
- dist tag is there
- no build root or other obsolete stuff
- license is ok, file present and installed
- latest version
- follows Mono guidelines
- %files is OK

rpmlint nini:
nini.src:37: E: hardcoded-library-path in %{_prefix}/lib/nini
nini.src:39: E: hardcoded-library-path in %{_prefix}/lib/nini/
nini.src:46: E: hardcoded-library-path in %{_prefix}/lib/nini/
It's OK per mono guidelines.

nini.src:41: W: macro-in-comment %{name}
nini.src:41: W: macro-in-comment %{buildroot}
nini.src:41: W: macro-in-comment %{_prefix}
That comment could be removed.

nini.src: W: invalid-url Source0: http://downloads.sourceforge.net/project/nini/Nini/1.1.0/Nini-1.1.0.zip timed out
Works for me.

% rpmlint nini-devel
nini-devel.noarch: W: no-documentation
nini-devel.noarch: W: spurious-executable-perm /usr/share/pkgconfig/nini.pc
${SOURCE1} should be -x.

Nice and clean module issues noted above.

Package is APPROVED.

Comment 2 Christopher Meng 2013-11-19 12:25:23 UTC
New Package SCM Request
=======================
Package Name: nini
Short Description: An uncommonly powerful .NET configuration library
Owners: cicku
Branches: f20

Comment 3 Gwyn Ciesla 2013-11-19 12:59:24 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-11-21 02:15:58 UTC
nini-1.1.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nini-1.1.0-1.fc20

Comment 5 Fedora Update System 2013-11-21 09:31:37 UTC
nini-1.1.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nini-1.1.0-2.fc20

Comment 6 Christopher Meng 2013-11-24 00:03:45 UTC
*** Bug 605840 has been marked as a duplicate of this bug. ***

Comment 7 Christopher Meng 2013-11-24 00:05:40 UTC
*** Bug 759139 has been marked as a duplicate of this bug. ***

Comment 8 Fedora Update System 2013-11-24 03:27:59 UTC
nini-1.1.0-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 9 Fedora Update System 2013-12-14 03:01:02 UTC
nini-1.1.0-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.