Bug 1001998
Summary: | Firefox (download) notifications no longer show up in the gnome 3 message tray | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | firefox | Assignee: | Martin Stransky <stransky> |
Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | gecko-bugs-nobody, hdegoede, johannbg, leigh123linux, martin, mszpak, seleznev.ru, stransky, vondruch |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-10-16 14:26:08 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Hans de Goede
2013-08-28 09:46:31 UTC
This is not F20 specific. I first noticed the same issue on F19. There are similar issues in KDE (see bug 1002897). Note I've recently (after a thunderbird upgrade) noticed that thunderbird is no showing the same problem. (In reply to Hans de Goede from comment #2) > Note I've recently (after a thunderbird upgrade) noticed that thunderbird is > no showing the same problem. I can't agree. TB is even more annoying than FF. I was even thinking about disabling TB notifications due to this. $ rpm -q thunderbird thunderbird-24.0-3.fc20.x86_64 It's because mozilla is redesigning the notification - https://bugzilla.mozilla.org/show_bug.cgi?id=782211 The Thunderbird bug - https://bugzilla.mozilla.org/show_bug.cgi?id=853104 Discussion to this topics: https://groups.google.com/forum/#!topic/mozilla.dev.platform/77i4nntE2Ug Unfortunately libnotify does not support all features needed by Mozilla notification system (which it's used for WebApps too). *** Bug 1023280 has been marked as a duplicate of this bug. *** Note this is affects F18 as well and seems to be 101 example how not to be maintaining and pushing things into GA releases... (In reply to Jóhann B. Guðmundsson from comment #9) > Note this is affects F18 as well and seems to be 101 example how not to be > maintaining and pushing things into GA releases... Unfortunately Mozilla rewrote the notification engine and drop libnotify backend because libnotify does not support all features Firefox needs (like clickable events). There isn't an easy fix for that - libnotify needs to be extended or we can write a partial libnotify support - but it's not something we can do in short timeframe. (In reply to Martin Stransky from comment #10) > (In reply to Jóhann B. Guðmundsson from comment #9) > > Note this is affects F18 as well and seems to be 101 example how not to be > > maintaining and pushing things into GA releases... > > Unfortunately Mozilla rewrote the notification engine and drop libnotify > backend because libnotify does not support all features Firefox needs (like > clickable events). > > There isn't an easy fix for that - libnotify needs to be extended or we can > write a partial libnotify support - but it's not something we can do in > short timeframe. Yes but the proper way to handle this would have been to stick to the tb that did not break this then to backport the necessary patches from tb without breaking the notification people are used to in GA releases and ones the notification support would be in place update both components. The change affects Thunderbird as well. The old notification support has been removed from all new Mozilla products. The "backport" here means to revert the new notification API and use the old one. I'm not sure how long we can maintain Fedora specific patch would be ~1-2MB big and goes outdated with every new release. (In reply to Martin Stransky from comment #12) > The change affects Thunderbird as well. The old notification support has > been removed from all new Mozilla products. The "backport" here means to > revert the new notification API and use the old one. I'm not sure how long > we can maintain Fedora specific patch would be ~1-2MB big and goes outdated > with every new release. TB should never have been updated in the GA releases until this was resolved, It's an very noticeable change for users and it's simply is the price to pay being a distribution maintainer for Mozilla when they make changes like this. Looking at the upstream report the libnotify maintainer(s) have had atleast since Mars more if the mozilla dev gave them a heads up before removing/implementing their notification changes to the core api. JFYI, I am not sure what is the future of libnotify, since it seems that it is going to be replaced by something else: http://blogs.gnome.org/mclasen/2013/10/14/montreal-summit/ May be Gnome could at least collaborate with Mozilla to find some common specification of notifications. (In reply to Martin Stransky from comment #12) > The change affects Thunderbird as well. The old notification support has > been removed from all new Mozilla products. The "backport" here means to > revert the new notification API and use the old one. I'm not sure how long > we can maintain Fedora specific patch would be ~1-2MB big and goes outdated > with every new release. It looks fairly easy to revert this for thunderbird (9.5kb) http://leigh123linux.fedorapeople.org/pub/patches/revert-removal-of-native-notifications.patch Yes, it's because Thunderbird is based on Firefox 24 ESR so it's not changed so heavily. I'm going to test the patch, it may buy us some time. But it's a temporary solution and obsoleted by Firefox/Thunderbird 32. (In reply to Martin Stransky from comment #16) > Yes, it's because Thunderbird is based on Firefox 24 ESR so it's not changed > so heavily. I'm going to test the patch, it may buy us some time. But it's a > temporary solution and obsoleted by Firefox/Thunderbird 32. Thank you. Please test new packages with new upstream patches: http://koji.fedoraproject.org/koji/buildinfo?buildID=585608 http://koji.fedoraproject.org/koji/buildinfo?buildID=585611 http://koji.fedoraproject.org/koji/buildinfo?buildID=585609 Hi Martin, (In reply to Martin Stransky from comment #18) > Please test new packages with new upstream patches: > > http://koji.fedoraproject.org/koji/buildinfo?buildID=585608 > http://koji.fedoraproject.org/koji/buildinfo?buildID=585611 > http://koji.fedoraproject.org/koji/buildinfo?buildID=585609 Thanks for your work on this! AFAIK firefox no longer shows download completions as system notifcations, instead it only changes the collor of the download error in its own UI now. At least I do not remember seeing any of the old-style notifications for a couple of firefox releases now. So although I would love to test this for you, I've no idea how to test :| Okay, Thanks. So closing for now. |