Bug 1008880
| Summary: | Some serious logs don't support localization - JMX | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Petr Kremensky <pkremens> |
| Component: | JMX | Assignee: | Brian Stansberry <brian.stansberry> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nikoleta Hlavickova <nziakova> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.2.0 | CC: | brian.stansberry, hrupp, kkhan, nziakova |
| Target Milestone: | DR1 | ||
| Target Release: | EAP 6.4.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Reassigning to web services. RemoteDeployer is used for test purposes only [1], so there's no need for it to support localization. ServiceMBeanSupport is not part of the webservices subsystem or ws components. [1] more in details, it's a support class used by the jbossws testsuite to deploy/undeploy test archives There are still some failures in EAP 6.3.0 DR0:
jboss-eap-6.3-src/system-jmx/src/main/java/org/jboss/system/ServiceMBeanSupport.java
379 log.error(e);
jboss-eap-6.3-src/osgi/service/src/main/java/org/jboss/as/osgi/service/InitialDeploymentTracker.java
132 LOGGER.warnf("ServiceStartFailed: %s", serviceName);
jboss-eap-6.3-src/osgi/integration/http/src/main/java/org/jboss/as/osgi/httpservice/HttpServiceImpl.java
197 WEB_LOGGER.errorf(e, "");
jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/PatchArtifact.java
102 ctx.getErrorHandler().error("Failed to load identity info for patch " + patch.getPatchId(), e);
116 ctx.getErrorHandler().error("Failed to load previous patch", e);
jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/XmlFileState.java
51 ctx.getErrorHandler().error("File doesn't exist: " + file.getAbsolutePath());
56 ctx.getErrorHandler().error("Failed to parse file: " + file.getAbsolutePath(), e);
jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/PatchElementProviderArtifact.java
84 ctx.getErrorHandler().error("Layer not found: " + metadata.getName());
jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/runner/IdentityPatchContext.java
435 PatchLogger.ROOT_LOGGER.warnf(e, "failed to undo change (%s)", modification);
jboss-eap-6.3-src/ejb3/src/main/java/org/jboss/as/ejb3/tx/CMTTxInterceptor.java
169 EjbLogger.ROOT_LOGGER.error(t);
Please file separate bugs per component, assigned to the relevant component lead. I'll use this one for the ServiceMBeanSupport one, as that is the component relevant to the initial report. Never mind this time; I'll do them all. It's easier. I have filed 2 BZs already: BZ #1067019 and BZ #1067020 And here is the 3rd (last) one: BZ #1067024 The only fail in EAP 6.3.0.ER9 in JMX is: jboss-eap-6.3-src/system-jmx/src/main/java/org/jboss/system/ServiceMBeanSupport.java - 379 log.error(e); I didn't submit my planned PR for this because the upstream changes couldn't be merged until after 6.3 work was in blockers-only mode. I'll send up a PR today but I expect it won't be merged for 6.3.0. Withdrawing my dev_ack for 6.3 as it is too late for the WFLY-2964 backport. The PR for the backport for 6.4 is https://github.com/jbossas/jboss-eap/pull/1505 Verified with EAP 6.4.0.DR1.1 |
There are some serious log messages which don't support localization. jboss-eap-6.2-src/webservices/tests-integration/src/main/java/org/jboss/as/webservices/deployer/RemoteDeployer.java - 152 LOGGER.warn("Trying to undeploy archive " + archiveURL + " which is not currently deployed!"); jboss-eap-6.2-src/system-jmx/src/main/java/org/jboss/system/ServiceMBeanSupport.java - 165 log.warn("Error in stop " + jbossInternalDescription(), t); - 173 log.warn("Error in destroy " + jbossInternalDescription(), t); - 220 log.warn("Initialization failed " + jbossInternalDescription(), e); - 253 log.warn("Starting failed " + jbossInternalDescription(), e); - 286 log.warn("Stopping failed " + jbossInternalDescription(), e); - 317 log.warn("Destroying failed " + jbossInternalDescription(), t);