Bug 1010741

Summary: Review Request: python-nikola - Static website and blog generator
Product: [Fedora] Fedora Reporter: Pete Travis <me>
Component: Package ReviewAssignee: Christopher Meng <i>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cristian.ciupitu, i, jamatos, mail, mario.blaettermann, me, mrunge, samuel-rhbugs
Target Milestone: ---Flags: i: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-nikola-6.4.0-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-16 10:10:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 971737, 1016095, 1028774, 1028816, 1030751, 1030755, 1030968, 1050805, 1075410, 1302197, 1718682    
Bug Blocks:    

Description Pete Travis 2013-09-22 22:33:45 UTC 
Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec
SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.0.1-1.fc21.src.rpm
Description:Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source
 can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries.
Comment 1 Pete Travis 2013-09-22 22:34:04 UTC 
*** Bug 882482 has been marked as a duplicate of this bug. ***
Comment 2 Christopher Meng 2013-09-23 00:49:58 UTC 
URL is http://getnikola.com/

Please update to the latest.
Comment 3 Christopher Meng 2013-09-23 00:58:44 UTC 
Also need to be fixed:

No python3 support.

Leave a blank line between each changelog

Not good:"/usr/bin/nikola"

python 2.x stuffs need macro %__python2 and same to sitelib.

Wrong:"BuildRequires:	python	"--> "BuildRequires:	python2-devel" at least.
Comment 4 Pete Travis 2013-10-05 02:55:31 UTC 
Updated to 6.1.0, changed to main project github for source, added python3, and some other adjustments.

Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec
SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.1.0-1.fc21.src.rpm
Description:Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries.
Comment 5 Christopher Meng 2013-10-07 13:05:59 UTC 
1. %package -n python-nikola-doc
Summary:	Documentation for Nikola, a static site generator
%description -n python-nikola-doc
python-nikola-doc contains detailed usage instructions for Nikola, a static
website and blog generator in python.

Just

%package doc is OK.

2. fedora-review:

---------------

ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', 'install', '/home/rpmaker/Desktop/python-nikola/results/python-nikola-6.1.0-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-nikola/results/python3-nikola-6.1.0-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-nikola/results/python-nikola-doc-6.1.0-1.fc21.noarch.rpm', '--setopt=tsflags=nocontexts']
Error: Package: python-nikola-6.1.0-1.fc21.noarch (/python-nikola-6.1.0-1.fc21.noarch)
           Requires: python-pyRSS2Gen
Error: Package: python3-nikola-6.1.0-1.fc21.noarch (/python3-nikola-6.1.0-1.fc21.noarch)
           Requires: python3-pyRSS2Gen
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest


It's PyRSS2Gen...

~~~~~~~~~~~~~~~~

- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find MIT-LICENSE.txt in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
Comment 6 Pete Travis 2013-10-08 15:55:23 UTC 
python*-RSS2Gen is available in my repos and mock builds successfully here. Time for a `mock clean`, maybe?
Comment 7 Christopher Meng 2013-10-08 15:58:30 UTC 
Your spec:

python-pyRSS2Gen

Repo:

python-PyRSS2Gen
Comment 8 Mario Blättermann 2013-10-15 15:06:44 UTC 
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6062587

(In reply to Christopher Meng from comment #7)
> Your spec:
> 
> python-pyRSS2Gen
> 
> Repo:
> 
> python-PyRSS2Gen

Indeed, it's the missing capitalized P which lets Mock fail. The build itself doesn't fail, but it will be impossible to solve the dependencies.


%{_mandir}/man1/nikola.1.gz

It is usual (but you are not forced to by the guidelines as far as I can see) to don't declare an explicite compression format for man pages. Just write

%{_mandir}/man1/nikola.1.*

to make it more future-proof. The default compression algorithm for man pages could change in the future.


%{_bindir}/python3-nikola
%{_mandir}/man1/nikola.1.*

This could cause irritations. The executable script in the py3 package is "python3-nikola" but the manpage is just named "nikola". Rpmlint will complain about this. As you did in the py2 package, create a symlink named "nikola3" pointing to python3-nikola and rename the man page. Keep in mind, py2 and py3 versions of a package are to be considered as completely independent from each other. 


What about the translations in the tarball in translations/nikola.messages? I can't find them anywhere in the resulting packages.


The base packages don't contain docs. Please add the files included in the tarball as %doc:
AUTHORS.txt
CHANGES.txt
CONTRIBUTING.rst
LICENSE.txt
README.rst
Comment 9 Christopher Meng 2013-10-18 03:44:11 UTC 
Have you realized the problem?
Comment 10 Pete Travis 2013-10-19 06:48:54 UTC 
Thanks for the insights, Mario and Christopher. I'll make the needed changes, and investigate the translations as well.

I haven't had much time for this recently, but hope to get another revision out soon.
Comment 11 Pete Travis 2013-10-26 20:53:36 UTC 
I've cleaned up %build; in playing with python3 and symlinks I realized that the build/ generated there overlapped between python2 and python2 builds. There's now /usr/bin/{nikola2,nikola3} and manpages for each; /usr/bin/nikola links to nikola2, and `man nikola` isn't there because the only way I could see to make a symlink to the compressed manpage that would survive a change of compression methods was in %post, and `rpmlint` didn't like that. Added the suggested documentation.

I believe the translations are for the default/demo site template. You can find the result of the translations in %{python*_sitelib}/nikola/data/themes/$themename/messages/

I also noticed a versioned dependency of the latest nikola releases that isn't fulfilled in Fedora, on python-doit. [ https://bugzilla.redhat.com/show_bug.cgi?id=1016095 ]. Please review 6.0.4 for now.

=================================================================

Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec
SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.0.4-2.fc21.src.rpm
Description:Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source
 can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries.
Comment 12 Christopher Meng 2013-11-08 13:38:42 UTC 
As doit 0.23 is landing Fedora, please build the latest nikola.
Comment 13 Pete Travis 2013-11-10 23:39:35 UTC 
Here's the latest, as requested. Complete functionality pending #1028774. 

Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec
SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.2.1-1.fc21.src.rpm
Description:Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source
 can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries.
Comment 14 Christopher Meng 2013-11-12 16:00:40 UTC 
I may hit a bug of mock:

http://ur1.ca/g0tox
Comment 15 Pete Travis 2013-11-15 02:11:09 UTC 
I can't replicate this here.  First attempt at `fedora-review -b 1010741` *did* give a short traceback; then mock reinitialized the buildroot and continued operation. `fedora-review -n python-nikola` on local files produced the same review.txt, fwiw. Try a `mock clean`, maybe?
Comment 16 Christopher Meng 2013-11-15 04:29:50 UTC 
mock clean 3 times so far and still failed with:

  File "/usr/lib/python2.7/site-packages/FedoraReview/deps.py", line 183, in listpaths
    path, mode = line.rsplit(None, 10)[0:5:4]
ValueError: need more than 1 value to unpack

Are you using rawhide? I think I have to open a bug report against mock.

-----------------

Besides this:

1. Better to leave a blank line between %package and %description

2. I'm working on packaging optional deps here now, then will block this bug again.
Comment 17 Pete Travis 2013-11-15 04:58:05 UTC 
I'm using rawhide for mock, but my local system is F20 and I think that's what fedora-review used. After taking a closer look, the review.txt's I diffed were empty. Do'h! Explicitly asking fedora-review to rawhide still fails, I'll do some experimenting.

1. I can do, no problem - but please don't block my review on *optional* features.  Really, this software has more than a handful of niche features, and the development team adds more quite often - this could drag out for quite a while.
Comment 18 Christopher Meng 2013-11-15 05:04:28 UTC 
(In reply to Pete Travis from comment #17)
> 1. I can do, no problem - but please don't block my review on *optional*
> features.  Really, this software has more than a handful of niche features,
> and the development team adds more quite often - this could drag out for
> quite a while.

Of course not ;) Don't worry, this bug is more like a tracker so we can do better in the future.
Comment 19 Pete Travis 2013-11-15 05:15:46 UTC 
Cool, thanks for working on the deps!

Found the problem - no %files for python3-nikola-extras.  Go ahead and give fedora-review another go.
Comment 20 Pete Travis 2013-11-27 06:39:50 UTC 
Just checking in - are you waiting on something from me before continuing the review, Christopher?
Comment 21 Christopher Meng 2013-11-28 02:32:55 UTC 
Ah..A bit busy now.

Will finish after a while.
Comment 22 Christopher Meng 2013-11-28 05:21:00 UTC 
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.n67wU0
+ umask 022
+ cd /builddir/build/BUILD
+ cd nikola-6.2.1
+ DOCDIR=/builddir/build/BUILDROOT/python-nikola-6.2.1-1.fc21.i386/usr/share/doc/doc
+ export DOCDIR
+ /usr/bin/mkdir -p /builddir/build/BUILDROOT/python-nikola-6.2.1-1.fc21.i386/usr/share/doc/doc
+ cp -pr docs/creating-a-site.txt docs/creating-a-theme.txt docs/extending.txt docs/internals.txt docs/manual.txt docs/social_buttons.txt docs/theming.txt docs/upgrading-to-v6.txt /builddir/build/BUILDROOT/python-nikola-6.2.1-1.fc21.i386/usr/share/doc/doc
+ exit 0
Provides: doc = 6.2.1-1.fc21
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/python-nikola-6.2.1-1.fc21.i386
error: Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/nikola.1.gz
RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/nikola.1.gz
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps  builddir/build/SPECS/python-nikola.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 376, in do
    raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps  builddir/build/SPECS/python-nikola.spec']
LEAVE do --> EXCEPTION RAISED
Comment 23 Pete Travis 2013-11-29 23:48:16 UTC 
Oops, that should be fixed now.
Comment 24 Christopher Meng 2013-11-30 13:06:51 UTC 
URL?
Comment 25 Pete Travis 2013-11-30 18:46:39 UTC 
Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec
SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.2.1-1.fc21.src.rpm
Description:Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries.
Comment 26 Christopher Meng 2013-12-02 09:57:37 UTC 
Apparently not fixed yet after running fedora-review again:

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/nikola.1.gz
Comment 27 Pete Travis 2013-12-04 16:45:54 UTC 
I can't replicate that.  If you look at the spec, you see that I'm manually installing nikola2(1) with the python2 package and nikola3(1) with the python3 package. There is no /usr/share/man/man1/nikola.1.gz installed. fedora-review does not give that complaint here.
Comment 28 Christopher Meng 2013-12-05 04:04:00 UTC 
Sorry, after mock root cleaning up, review process could run well.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "Unknown or generated". 63 files have unknown
     license. Detailed output of licensecheck:


MIT/X11 (BSD like)
------------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/filters.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/main.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/nikola.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugin_categories.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/basic_import.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/auto.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/bootswatch_theme.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/console.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/deploy.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/import_blogger.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/import_feed.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/import_wordpress.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/init.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/install_plugin.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/install_theme.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/new_post.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/planetoid/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/serve.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/version.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/asciidoc.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/bbcode.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/html.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/ipynb/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/mdx_gist.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/mdx_nikola.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/mdx_podcast.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/misaka.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/pandoc.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/php.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/chart.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/doc.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/listing.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/media.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/post_list.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/slides.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/vimeo.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/youtube.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/textile.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/txt2tags.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/wiki.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/loghandler/smtp.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/loghandler/stderr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/archive.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/build_less.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/build_sass.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/bundles.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/copy_assets.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/copy_files.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/galleries.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/gzip.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/indexes.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/listings.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/localsearch/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/mustache/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/pages.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/posts.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/redirect.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/rss.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/sitemap/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/sources.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/tags.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/template/jinja.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/template/mako.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/post.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/rc4.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/utils.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/winutils.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/setup.py

Unknown or generated
--------------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/docs/sphinx/conf.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/samplesite/listings/hello.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_bg.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_ca.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_de.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_el.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_en.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_eo.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_es.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_fa.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_fi.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_fr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_hr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_it.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_ja.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_nl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_pl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_pt_br.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_ru.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_sl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_sl_si.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_tr_tr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_zh_cn.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ach.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_bg.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ca.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_de.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_el.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_en.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_es.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_fa.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_fr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_gr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_hr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_it.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ja.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_pl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_pt_br.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ru.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_tr_tr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_zh_cn.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/check.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/mincss.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/gist.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/soundcloud.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/scripts/import_po.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/scripts/set_version.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/base.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/context.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/data/translated_titles/conf.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/import_wordpress_and_build_workflow.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_command_import_wordpress.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_command_init.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_compile_markdown.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_integration.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_locale.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_plugin_importing.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_rss_feeds.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_rst_compiler.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_scheduling.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_utils.py


[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[1]: Package is named according to the Package Naming Guidelines.

------>

%package -n doc
Summary:	Documentation for Nikola, a static site generator
%description -n doc
python-nikola-doc contains detailed usage instructions for Nikola, a static
website and blog generator in python.

You name a package "doc", that's explicitly wrong...

%package doc
Summary:	Documentation for Nikola, a static site generator
%description doc

python-nikola-doc contains detailed usage instructions for Nikola, a static
website and blog generator in python.

Please leave a blank line between %package and %description. Also this incorrect naming should be fixed in %files.

[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 256000 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
     nikola-extras , python3-nikola , python3-nikola-extras , doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Installation errors
-------------------
INFO: mock.py version 1.1.35 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.35
INFO: Mock Version: 1.1.35
Start: lock buildroot
INFO: installing package(s): /home/rpmaker/Desktop/python-nikola/results/python-nikola-6.2.1-1.fc21.noarch.rpm /home/rpmaker/Desktop/python-nikola/results/python-nikola-extras-6.2.1-1.fc21.noarch.rpm /home/rpmaker/Desktop/python-nikola/results/python3-nikola-6.2.1-1.fc21.noarch.rpm /home/rpmaker/Desktop/python-nikola/results/python3-nikola-extras-6.2.1-1.fc21.noarch.rpm /home/rpmaker/Desktop/python-nikola/results/doc-6.2.1-1.fc21.noarch.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', 'install', '/home/rpmaker/Desktop/python-nikola/results/python-nikola-6.2.1-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-nikola/results/python-nikola-extras-6.2.1-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-nikola/results/python3-nikola-6.2.1-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-nikola/results/python3-nikola-extras-6.2.1-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-nikola/results/doc-6.2.1-1.fc21.noarch.rpm', '--setopt=tsflags=nocontexts']
Error: Package: gstreamer-plugins-base-0.10.36-6.fc21.i686 (fedora)
           Requires: libvisual-0.4.so.0
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest

------> This is caused by libvisual bumping in rawhide, no worries. ;)

Rpmlint
-------
Checking: python-nikola-6.2.1-1.fc21.noarch.rpm
          python-nikola-extras-6.2.1-1.fc21.noarch.rpm
          python3-nikola-6.2.1-1.fc21.noarch.rpm
          python3-nikola-extras-6.2.1-1.fc21.noarch.rpm
          doc-6.2.1-1.fc21.noarch.rpm
          python-nikola-6.2.1-1.fc21.src.rpm
python-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure
python-nikola.noarch: W: no-manual-page-for-binary nikola
python3-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure

------? I'm not a native English speaker, but I think we can improve it?

doc.noarch: W: spelling-error %description -l en_US nikola -> Nikolai
python-nikola.src: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python-nikola.src: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure


python-nikola.src:99: W: mixed-use-of-spaces-and-tabs (spaces: line 99, tab: line 2)

------> Fix it please.

6 packages and 0 specfiles checked; 0 errors, 9 warnings.




Requires
--------
python3-nikola (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)

--> Verified, Requires: /usr/bin/python3 python(abi) = 3.3, OK.

    python3-PyRSS2Gen
    python3-blinker
    python3-docutils
    python3-doit
    python3-logbook
    python3-lxml
    python3-mako
    python3-pillow
    python3-pygments
    python3-pytz
    python3-unidecode
    python3-yapsy

doc (rpmlib, GLIBC filtered):

python-nikola-extras (rpmlib, GLIBC filtered):
    python-dateutil
    python-jinja2
    python-markdown
    python-mock
    python-nikola
    python-pyphen
    python-requests

python-nikola (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)

--> Verified, Requires: /usr/bin/python2 python(abi) = 2.7, OK.

    python-PyRSS2Gen
    python-blinker
    python-docutils
    python-doit
    python-logbook
    python-lxml
    python-mako
    python-pillow
    python-pygments
    python-unidecode
    python-yapsy
    pytz

python3-nikola-extras (rpmlib, GLIBC filtered):
    python3-dateutil
    python3-ipython
    python3-jinja2
    python3-markdown
    python3-mock
    python3-nikola
    python3-pyphen
    python3-requests



Provides
--------
python3-nikola:
    python3-nikola

doc:
    doc

---> WRONG!!!

python-nikola-extras:
    python-nikola-extras

python-nikola:
    python-nikola

python3-nikola-extras:
    python3-nikola-extras



Source checksums
----------------
https://github.com/getnikola/nikola/archive/v6.2.1.tar.gz :
  CHECKSUM(SHA256) this package     : 89401d321f769cc35b0a5ca92323d1655f6dedd2e6bd84ec3fc03b464f065691
  CHECKSUM(SHA256) upstream package : 89401d321f769cc35b0a5ca92323d1655f6dedd2e6bd84ec3fc03b464f065691


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -rvn python-nikola-6.2.1-1.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, C/C++, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

----------------
Nearly approved!
Comment 29 Pete Travis 2013-12-05 07:41:52 UTC 
The "doc" package stemmed from my misinterpreting your suggestion in Comment 5. I've changed the spec to use full package names, for consistency.

The spell check complaints can be ignored. Nikola and ReStructuredText are not in the dictionary, and that's ok. "unformatted" isn't either, but it is a compound word composed of common prefixes and suffixes in a generally accepted way. Some dictionaries might list this word, it just happens that the one fedora-review used does not.

Line 99, of mixed spaces and tabs report, is a commented out optional dependency. I don't think it will cause any issues for my comments to have spaces.
Comment 30 Christopher Meng 2013-12-05 09:57:19 UTC 
BTW, I have an extra suggestion which is epitomized in my packages:

1. Name python3 binary from xxx3 to xxx-%{python3_version}

2. %{python3_sitelib}/Nikola-%{version}-py3.3.egg-info

-->

%{python3_sitelib}/Nikola-%{version}-py%{python3_version}.egg-info

Also,

%{python2_sitelib}/Nikola-%{version}-py2.7.egg-info

-->

%{python2_sitelib}/Nikola-%{version}-py%{python2_version}.egg-info

Also, what about this?

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
Comment 31 Pete Travis 2013-12-06 02:53:49 UTC 
I noticed the font thing too. The licenses of the font and the theme that includes the font allow such redistribution, but I've sent a mail to the fonts sig list to be sure.
Comment 32 Pete Travis 2014-01-09 06:50:29 UTC 
I've opened a separate review for the fonts, removed them from this package, put a symlink+dependency in their place, and implemented the macros suggested in Comment 30. Progress!
Comment 33 Pete Travis 2014-02-18 03:22:15 UTC 
Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec
SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.3.0-1.fc21.src.rpm
Description: Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries.
Comment 34 Pete Travis 2014-03-12 19:45:27 UTC 
Spec URL: http://immanetize.fedorapeople.org/python-nikola.spec
SRPM URL: http://immanetize.fedorapeople.org/python-nikola-6.4.0-1.fc21.src.rpm
Description: Nikola is a static site and blog generator using Python. It generates sites with tags, feeds, archives, comments, and more from plain text files. Source can be unformatted, or formatted with reStructuredText or Markdown. It also automatically builds image galleries.
Comment 35 José Matos 2014-03-14 16:29:23 UTC 
The changelog entry is missing for this update (a non issue, but in any case something that is missing). :-)
Comment 36 Pete Travis 2014-03-17 19:33:15 UTC 
Good cath, José, thanks! I've updated the files in place.
Comment 37 Pete Travis 2014-03-28 04:14:03 UTC 
ping!
Comment 38 Christopher Meng 2014-03-28 09:10:37 UTC 
pong.

I will review it in the weekend.
Comment 39 Christopher Meng 2014-04-20 11:12:34 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



Issues:
=======
- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find MIT-LICENSE.txt in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "Unknown or generated". 55 files have unknown
     license. Detailed output of licensecheck:

MIT/X11 (BSD like)
------------------
nikola-6.4.0/nikola/__init__.py
nikola-6.4.0/nikola/__main__.py
nikola-6.4.0/nikola/filters.py
nikola-6.4.0/nikola/nikola.py
nikola-6.4.0/nikola/plugin_categories.py
nikola-6.4.0/nikola/plugins/basic_import.py
nikola-6.4.0/nikola/plugins/command/__init__.py
nikola-6.4.0/nikola/plugins/command/auto.py
nikola-6.4.0/nikola/plugins/command/bootswatch_theme.py
nikola-6.4.0/nikola/plugins/command/console.py
nikola-6.4.0/nikola/plugins/command/deploy.py
nikola-6.4.0/nikola/plugins/command/import_blogger.py
nikola-6.4.0/nikola/plugins/command/import_feed.py
nikola-6.4.0/nikola/plugins/command/import_wordpress.py
nikola-6.4.0/nikola/plugins/command/init.py
nikola-6.4.0/nikola/plugins/command/install_plugin.py
nikola-6.4.0/nikola/plugins/command/install_theme.py
nikola-6.4.0/nikola/plugins/command/new_page.py
nikola-6.4.0/nikola/plugins/command/new_post.py
nikola-6.4.0/nikola/plugins/command/planetoid/__init__.py
nikola-6.4.0/nikola/plugins/command/serve.py
nikola-6.4.0/nikola/plugins/command/version.py
nikola-6.4.0/nikola/plugins/compile/__init__.py
nikola-6.4.0/nikola/plugins/compile/asciidoc.py
nikola-6.4.0/nikola/plugins/compile/bbcode.py
nikola-6.4.0/nikola/plugins/compile/html.py
nikola-6.4.0/nikola/plugins/compile/ipynb/__init__.py
nikola-6.4.0/nikola/plugins/compile/markdown/__init__.py
nikola-6.4.0/nikola/plugins/compile/markdown/mdx_gist.py
nikola-6.4.0/nikola/plugins/compile/markdown/mdx_nikola.py
nikola-6.4.0/nikola/plugins/compile/markdown/mdx_podcast.py
nikola-6.4.0/nikola/plugins/compile/misaka.py
nikola-6.4.0/nikola/plugins/compile/pandoc.py
nikola-6.4.0/nikola/plugins/compile/php.py
nikola-6.4.0/nikola/plugins/compile/rest/__init__.py
nikola-6.4.0/nikola/plugins/compile/rest/chart.py
nikola-6.4.0/nikola/plugins/compile/rest/doc.py
nikola-6.4.0/nikola/plugins/compile/rest/listing.py
nikola-6.4.0/nikola/plugins/compile/rest/media.py
nikola-6.4.0/nikola/plugins/compile/rest/post_list.py
nikola-6.4.0/nikola/plugins/compile/rest/slides.py
nikola-6.4.0/nikola/plugins/compile/rest/vimeo.py
nikola-6.4.0/nikola/plugins/compile/rest/youtube.py
nikola-6.4.0/nikola/plugins/compile/textile.py
nikola-6.4.0/nikola/plugins/compile/txt2tags.py
nikola-6.4.0/nikola/plugins/compile/wiki.py
nikola-6.4.0/nikola/plugins/loghandler/__init__.py
nikola-6.4.0/nikola/plugins/loghandler/smtp.py
nikola-6.4.0/nikola/plugins/loghandler/stderr.py
nikola-6.4.0/nikola/plugins/task/__init__.py
nikola-6.4.0/nikola/plugins/task/archive.py
nikola-6.4.0/nikola/plugins/task/build_less.py
nikola-6.4.0/nikola/plugins/task/build_sass.py
nikola-6.4.0/nikola/plugins/task/bundles.py
nikola-6.4.0/nikola/plugins/task/copy_assets.py
nikola-6.4.0/nikola/plugins/task/copy_files.py
nikola-6.4.0/nikola/plugins/task/galleries.py
nikola-6.4.0/nikola/plugins/task/gzip.py
nikola-6.4.0/nikola/plugins/task/indexes.py
nikola-6.4.0/nikola/plugins/task/listings.py
nikola-6.4.0/nikola/plugins/task/localsearch/__init__.py
nikola-6.4.0/nikola/plugins/task/mustache/__init__.py
nikola-6.4.0/nikola/plugins/task/pages.py
nikola-6.4.0/nikola/plugins/task/posts.py
nikola-6.4.0/nikola/plugins/task/redirect.py
nikola-6.4.0/nikola/plugins/task/rss.py
nikola-6.4.0/nikola/plugins/task/sitemap/__init__.py
nikola-6.4.0/nikola/plugins/task/sources.py
nikola-6.4.0/nikola/plugins/task/tags.py
nikola-6.4.0/nikola/plugins/template/__init__.py
nikola-6.4.0/nikola/plugins/template/jinja.py
nikola-6.4.0/nikola/plugins/template/mako.py
nikola-6.4.0/nikola/post.py
nikola-6.4.0/nikola/rc4.py
nikola-6.4.0/nikola/utils.py
nikola-6.4.0/nikola/winutils.py
nikola-6.4.0/setup.py
nikola-6.4.0/tests/__init__.py

Unknown or generated
--------------------
nikola-6.4.0/docs/sphinx/conf.py
nikola-6.4.0/dodo.py
nikola-6.4.0/nikola/data/samplesite/listings/hello.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_bg.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_ca.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_cs.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_cz.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_de.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_el.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_en.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_eo.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_es.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_et.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_eu.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_fa.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_fi.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_fr.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_hi.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_hr.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_it.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_ja.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_nb.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_nl.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_pl.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_pt_br.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_ru.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_sl.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_sl_si.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_tr.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_tr_tr.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_ur.py
nikola-6.4.0/nikola/data/themes/base/messages/messages_zh_cn.py
nikola-6.4.0/nikola/plugins/__init__.py
nikola-6.4.0/nikola/plugins/command/check.py
nikola-6.4.0/nikola/plugins/command/mincss.py
nikola-6.4.0/nikola/plugins/command/orphans.py
nikola-6.4.0/nikola/plugins/compile/rest/gist.py
nikola-6.4.0/nikola/plugins/compile/rest/soundcloud.py
nikola-6.4.0/scripts/getpyver.py
nikola-6.4.0/scripts/import_po.py
nikola-6.4.0/scripts/set_version.py
nikola-6.4.0/tests/base.py
nikola-6.4.0/tests/data/translated_titles/conf.py
nikola-6.4.0/tests/data/translated_titles/stories/1.txt.pl
nikola-6.4.0/tests/import_wordpress_and_build_workflow.py
nikola-6.4.0/tests/test_command_import_wordpress.py
nikola-6.4.0/tests/test_command_init.py
nikola-6.4.0/tests/test_compile_markdown.py
nikola-6.4.0/tests/test_integration.py
nikola-6.4.0/tests/test_locale.py
nikola-6.4.0/tests/test_plugin_importing.py
nikola-6.4.0/tests/test_rss_feeds.py
nikola-6.4.0/tests/test_rst_compiler.py
nikola-6.4.0/tests/test_scheduling.py
nikola-6.4.0/tests/test_utils.py

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 122880 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     https://github.com/getnikola/nikola/archive/v6.4.0.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
     nikola-extras , python3-nikola , python3-nikola-extras , python-nikola-
     doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python-nikola-6.4.0-1.fc21.noarch.rpm
          python-nikola-extras-6.4.0-1.fc21.noarch.rpm
          python3-nikola-6.4.0-1.fc21.noarch.rpm
          python3-nikola-extras-6.4.0-1.fc21.noarch.rpm
          python-nikola-doc-6.4.0-1.fc21.noarch.rpm
          python-nikola-6.4.0-1.fc21.src.rpm
python-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure
python-nikola.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings
python-nikola.noarch: W: no-manual-page-for-binary nikola
python3-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure
python3-nikola.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings
python3-nikola.noarch: W: no-manual-page-for-binary nikola3.3
python-nikola.src: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python-nikola.src: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure
python-nikola.src:101: W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 2)
python-nikola.src: W: invalid-url Source0: https://github.com/getnikola/nikola/archive/v6.4.0.tar.gz <urlopen error _ssl.c:492: The handshake operation timed out>
6 packages and 0 specfiles checked; 0 errors, 12 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python3-nikola python-nikola-doc python-nikola-extras pyth 
on-nikola python3-nikola-extras
python3-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure
python3-nikola.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings
python3-nikola.noarch: W: no-manual-page-for-binary nikola3.3
python-nikola.noarch: W: spelling-error %description -l en_US unformatted -> unformulated, formatted, unfortunate
python-nikola.noarch: W: spelling-error %description -l en_US reStructuredText -> restructured Text, restructured-text, restructure
python-nikola.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/nikola/data/themes/bootstrap3/assets/fonts /usr/share/fonts/glyphicons-halflings
python-nikola.noarch: W: no-manual-page-for-binary nikola
5 packages and 0 specfiles checked; 0 errors, 8 warnings.
# echo 'rpmlint-done:'



Requires
--------
python3-nikola (rpmlib, GLIBC filtered):
    /usr/bin/python3
    glyphicons-halflings-fonts
    python(abi)
    python3-PyRSS2Gen
    python3-blinker
    python3-colorama
    python3-docutils
    python3-doit
    python3-logbook
    python3-lxml
    python3-mako
    python3-pillow
    python3-pygments
    python3-pytz
    python3-unidecode
    python3-yapsy

python-nikola-doc (rpmlib, GLIBC filtered):

python-nikola-extras (rpmlib, GLIBC filtered):
    python-dateutil
    python-jinja2
    python-markdown
    python-mock
    python-nikola
    python-pygal
    python-pyphen
    python-requests
    python-webassets

python-nikola (rpmlib, GLIBC filtered):
    /usr/bin/python2
    glyphicons-halflings-fonts
    python(abi)
    python-PyRSS2Gen
    python-blinker
    python-colorama
    python-docutils
    python-doit
    python-logbook
    python-lxml
    python-mako
    python-pillow
    python-pygments
    python-unidecode
    python-yapsy
    pytz

python3-nikola-extras (rpmlib, GLIBC filtered):
    python3-dateutil
    python3-jinja2
    python3-markdown
    python3-mock
    python3-nikola
    python3-pygal
    python3-pyphen
    python3-requests
    python3-webassets



Provides
--------
python3-nikola:
    python3-nikola

python-nikola-doc:
    python-nikola-doc

python-nikola-extras:
    python-nikola-extras

python-nikola:
    python-nikola

python3-nikola-extras:
    python3-nikola-extras



Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -rvn python-nikola-6.4.0-1.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-------------------------------------
Fix W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 2) before SCM.

PACKAGE APPROVED.
Comment 40 Pete Travis 2014-04-20 13:59:30 UTC 
New Package SCM Request
=======================
Package Name: python-nikola
Short Description: Static website and blog generator
Owners: immanetize jamatos
Branches: f19 f20
Comment 41 Kevin Fenzi 2014-04-20 23:31:53 UTC 
Git done (by process-git-requests).
Comment 42 Fedora Update System 2014-04-22 03:19:16 UTC 
python-nikola-6.4.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-nikola-6.4.0-1.fc20
Comment 43 Fedora Update System 2014-04-23 04:30:38 UTC 
python-nikola-6.4.0-1.fc20 has been pushed to the Fedora 20 testing repository.
Comment 44 Fedora Update System 2014-05-16 10:10:05 UTC 
python-nikola-6.4.0-1.fc20 has been pushed to the Fedora 20 stable repository.