Bug 1015683

Summary: core/GUI: prevent potential serialization exceptions post upgrade to GWT 2.5
Product: [Retired] oVirt Reporter: Einav Cohen <ecohen>
Component: ovirt-engine-coreAssignee: Vojtech Szocs <vszocs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: urgent    
Version: 3.3CC: acathrow, amureini, iheim, scohen, yeylon, ykaul
Target Milestone: ---Keywords: CodeChange
Target Release: 3.3.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ux
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1029605 (view as bug list) Environment:
Last Closed: 2013-12-19 14:24:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1019626, 1028759, 1029605    

Description Einav Cohen 2013-10-04 20:34:21 UTC 
In GWT 2.5, there are stricter requirements for classes that are being (de)serialized via the GWT RPC (de)serialization mechanism:

a. class should have no member initialization (members should be initialized only within methods, typically c'tors)

b. class should have an explicit default c'tor.

need to change the relevant classes to comply with these requirements.

'b' is already taken care of by these patches [1]
still need to apply 'a' as well.


[1] by amureini:
http://gerrit.ovirt.org/#/c/18133/
http://gerrit.ovirt.org/#/c/18139/
http://gerrit.ovirt.org/#/c/18134/
http://gerrit.ovirt.org/#/c/18140/
http://gerrit.ovirt.org/#/c/18132/
http://gerrit.ovirt.org/#/c/18135/
http://gerrit.ovirt.org/#/c/18138/
http://gerrit.ovirt.org/#/c/18137/
Comment 1 Einav Cohen 2013-10-04 20:40:15 UTC 
(In reply to Einav Cohen from comment #0)
> 
> 'b' is already taken care of by these patches [1]
> still need to apply 'a' as well.

correction: should be the other way around: 
'a' (no member init) is already taken care of. 
still need to apply 'b' (explicit default c'tor).
Comment 2 Vojtech Szocs 2013-10-17 18:20:34 UTC 
(In reply to Einav Cohen from comment #1)
> (In reply to Einav Cohen from comment #0)
> > 
> > 'b' is already taken care of by these patches [1]
> > still need to apply 'a' as well.
> 
> correction: should be the other way around: 
> 'a' (no member init) is already taken care of. 
> still need to apply 'b' (explicit default c'tor).

No-argument constructor check is implemented in patch http://gerrit.ovirt.org/#/c/20274/
Comment 4 Vojtech Szocs 2013-11-21 19:56:58 UTC 
Patch http://gerrit.ovirt.org/#/c/20274/ updated and ready for review. Once merged into master, all relevant patches will be backported and BZ will be moved to MODIFIED.
Comment 5 Sandro Bonazzola 2013-12-13 16:01:57 UTC 
rc build done, moving to ON_QA, packages will be available on updates-testing repository.
Comment 6 Sandro Bonazzola 2013-12-19 14:24:21 UTC 
oVirt 3.3.2 has been released resolving the problem described in this bug report.