Bug 1015683 - core/GUI: prevent potential serialization exceptions post upgrade to GWT 2.5
Summary: core/GUI: prevent potential serialization exceptions post upgrade to GWT 2.5
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.3
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ---
: 3.3.2
Assignee: Vojtech Szocs
QA Contact:
URL:
Whiteboard: ux
Depends On:
Blocks: 1019626 1028759 1029605
TreeView+ depends on / blocked
 
Reported: 2013-10-04 20:34 UTC by Einav Cohen
Modified: 2016-01-28 21:56 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1029605 (view as bug list)
Environment:
Last Closed: 2013-12-19 14:24:21 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 18908 0 None None None Never
oVirt gerrit 20273 0 None None None Never
oVirt gerrit 20274 0 None None None Never
oVirt gerrit 21732 0 None None None Never
oVirt gerrit 21733 0 None None None Never

Description Einav Cohen 2013-10-04 20:34:21 UTC
In GWT 2.5, there are stricter requirements for classes that are being (de)serialized via the GWT RPC (de)serialization mechanism:

a. class should have no member initialization (members should be initialized only within methods, typically c'tors)

b. class should have an explicit default c'tor.

need to change the relevant classes to comply with these requirements.

'b' is already taken care of by these patches [1]
still need to apply 'a' as well.


[1] by amureini:
http://gerrit.ovirt.org/#/c/18133/
http://gerrit.ovirt.org/#/c/18139/
http://gerrit.ovirt.org/#/c/18134/
http://gerrit.ovirt.org/#/c/18140/
http://gerrit.ovirt.org/#/c/18132/
http://gerrit.ovirt.org/#/c/18135/
http://gerrit.ovirt.org/#/c/18138/
http://gerrit.ovirt.org/#/c/18137/

Comment 1 Einav Cohen 2013-10-04 20:40:15 UTC
(In reply to Einav Cohen from comment #0)
> 
> 'b' is already taken care of by these patches [1]
> still need to apply 'a' as well.

correction: should be the other way around: 
'a' (no member init) is already taken care of. 
still need to apply 'b' (explicit default c'tor).

Comment 2 Vojtech Szocs 2013-10-17 18:20:34 UTC
(In reply to Einav Cohen from comment #1)
> (In reply to Einav Cohen from comment #0)
> > 
> > 'b' is already taken care of by these patches [1]
> > still need to apply 'a' as well.
> 
> correction: should be the other way around: 
> 'a' (no member init) is already taken care of. 
> still need to apply 'b' (explicit default c'tor).

No-argument constructor check is implemented in patch http://gerrit.ovirt.org/#/c/20274/

Comment 4 Vojtech Szocs 2013-11-21 19:56:58 UTC
Patch http://gerrit.ovirt.org/#/c/20274/ updated and ready for review. Once merged into master, all relevant patches will be backported and BZ will be moved to MODIFIED.

Comment 5 Sandro Bonazzola 2013-12-13 16:01:57 UTC
rc build done, moving to ON_QA, packages will be available on updates-testing repository.

Comment 6 Sandro Bonazzola 2013-12-19 14:24:21 UTC
oVirt 3.3.2 has been released resolving the problem described in this bug report.


Note You need to log in before you can comment on or make changes to this bug.