Bug 1022177

Summary: ruby193-mcollective sysconfig should handle environment variables better
Product: OpenShift Online Reporter: Andy Grimm <agrimm>
Component: ContainersAssignee: Brenton Leanhardt <bleanhar>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 2.xCC: dmcphers, jgoulding, mmasters
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1055675 (view as bug list) Environment:
Last Closed: 2015-06-11 21:40:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1055675    

Description Andy Grimm 2013-10-22 16:04:57 UTC 
This is a minor thing, but the way /opt/rh/ruby193/root/etc/sysconfig/mcollective handles environment variable is inefficient and incorrect.  It calls "scl enable" three times and prepends to existing settings, but the SCL values already include the existing values, so this is unnecessary.  A correct, single scl call would be:

eval $( scl enable ruby193 'echo "export PATH=$PATH; export LD_LIBRARY_PATH=$LD_LIBRARY_PATH; export MANPATH=$MANPATH"' )
Comment 1 Dan McPherson 2014-01-20 17:58:39 UTC 
https://github.com/openshift/li/pull/2287
Comment 2 Dan McPherson 2014-01-20 18:21:04 UTC 
Brenton,  I realized this should actually be changed in the ruby193-mco rpm as well.
Comment 3 Miciah Dashiel Butler Masters 2014-01-20 18:48:58 UTC 
Duplicate of bug 1017248?
Comment 4 Miciah Dashiel Butler Masters 2014-01-20 18:50:00 UTC 
s/Duplicate of/Related to/
Comment 5 openshift-github-bot 2014-01-20 23:09:46 UTC 
Commit pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/c2317c3f8b4e9d8e1852935d3b379c96fe800725
Bug 1022177