Bug 1022177 - ruby193-mcollective sysconfig should handle environment variables better
Summary: ruby193-mcollective sysconfig should handle environment variables better
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1055675
TreeView+ depends on / blocked
 
Reported: 2013-10-22 16:04 UTC by Andy Grimm
Modified: 2016-11-08 03:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1055675 (view as bug list)
Environment:
Last Closed: 2015-06-11 21:40:21 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Andy Grimm 2013-10-22 16:04:57 UTC 
This is a minor thing, but the way /opt/rh/ruby193/root/etc/sysconfig/mcollective handles environment variable is inefficient and incorrect.  It calls "scl enable" three times and prepends to existing settings, but the SCL values already include the existing values, so this is unnecessary.  A correct, single scl call would be:

eval $( scl enable ruby193 'echo "export PATH=$PATH; export LD_LIBRARY_PATH=$LD_LIBRARY_PATH; export MANPATH=$MANPATH"' )
Comment 1 Dan McPherson 2014-01-20 17:58:39 UTC 
https://github.com/openshift/li/pull/2287
Comment 2 Dan McPherson 2014-01-20 18:21:04 UTC 
Brenton,  I realized this should actually be changed in the ruby193-mco rpm as well.
Comment 3 Miciah Dashiel Butler Masters 2014-01-20 18:48:58 UTC 
Duplicate of bug 1017248?
Comment 4 Miciah Dashiel Butler Masters 2014-01-20 18:50:00 UTC 
s/Duplicate of/Related to/
Comment 5 openshift-github-bot 2014-01-20 23:09:46 UTC 
Commit pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/c2317c3f8b4e9d8e1852935d3b379c96fe800725
Bug 1022177
Note You need to log in before you can comment on or make changes to this bug.