Bug 1055675 - ruby193-mcollective sysconfig should handle environment variables better
Summary: ruby193-mcollective sysconfig should handle environment variables better
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Containers
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On: 1022177
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-20 18:28 UTC by Brenton Leanhardt
Modified: 2017-03-08 17:36 UTC (History)
7 users (show)

Fixed In Version: ruby193-mcollective-2.2.3-5.el6op
Doc Type: Enhancement
Doc Text:
The environment variable handling in the MCollective service has been optimized for efficiency.
Clone Of: 1022177
Environment:
Last Closed: 2014-02-25 15:43:18 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:0209 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.0.3 bugfix and enhancement update 2014-02-25 20:40:32 UTC

Description Brenton Leanhardt 2014-01-20 18:28:14 UTC
+++ This bug was initially created as a clone of Bug #1022177 +++

This is a minor thing, but the way /opt/rh/ruby193/root/etc/sysconfig/mcollective handles environment variable is inefficient and incorrect.  It calls "scl enable" three times and prepends to existing settings, but the SCL values already include the existing values, so this is unnecessary.  A correct, single scl call would be:

eval $( scl enable ruby193 'echo "export PATH=$PATH; export LD_LIBRARY_PATH=$LD_LIBRARY_PATH; export MANPATH=$MANPATH"' )

--- Additional comment from Dan McPherson on 2014-01-20 12:58:39 EST ---

https://github.com/openshift/li/pull/2287

--- Additional comment from Dan McPherson on 2014-01-20 13:21:04 EST ---

Brenton,  I realized this should actually be changed in the ruby193-mco rpm as well.

Comment 4 Gaoyun Pei 2014-01-23 01:41:46 UTC
verify this bug with ruby193-mcollective-2.2.3-5.el6op.noarch

ruby193-mcollective sysconfig has changed to a correct single scl call

[root@broker ~]# cat /opt/rh/ruby193/root/etc/sysconfig/mcollective
eval $( scl enable ruby193 'echo "export PATH=$PATH; export LD_LIBRARY_PATH=$LD_LIBRARY_PATH; export MANPATH=$MANPATH"' )

and mcollective works well.

Comment 6 errata-xmlrpc 2014-02-25 15:43:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0209.html


Note You need to log in before you can comment on or make changes to this bug.