Bug 1023620

Summary:	broken ppp-2.4.5-eaptls-mppe-0.99.patch
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	ppp	Assignee:	Michal Sekletar <msekleta>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	20	CC:	jsynacek, msekleta, thozza
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	ppp-2.4.5-35.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1173012 (view as bug list)		Environment:
Last Closed:	2015-01-07 23:55:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1173012

Description David Binderman 2013-10-26 07:28:32 UTC

I just compiled ppp-2.4.5 with extra gcc compiler flag -Wlogical-op

It said

> eap.c:236:2: warning: logical 'or' of collectively exhaustive tests is always 
true [-Wlogical-op]
> eap.c:1154:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:1189:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2413:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2457:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]

It looks like the compiler is complaining about the eap_client_active macro.
It is defined in patch file ppp-2.4.5-eaptls-mppe-0.99.patch as follows

+#define    eap_client_active(esp)  ((esp)->es_client.ea_state != eapInitial ||\
+                (esp)->es_client.ea_state != eapPending ||\
+                (esp)->es_client.ea_state != eapClosed)

Suggest swap || for &&

Comment 1 Fedora Update System 2014-12-11 09:57:52 UTC

ppp-2.4.5-35.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ppp-2.4.5-35.fc20

Comment 2 Fedora Update System 2014-12-11 09:59:51 UTC

ppp-2.4.7-6.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/ppp-2.4.7-6.fc21

Comment 3 Fedora Update System 2014-12-13 09:37:57 UTC

Package ppp-2.4.5-35.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ppp-2.4.5-35.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-16810/ppp-2.4.5-35.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2015-01-07 23:55:15 UTC

ppp-2.4.7-6.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2015-01-07 23:56:14 UTC

ppp-2.4.5-35.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.