RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1173012 - broken ppp-2.4.5-eaptls-mppe-0.99.patch
Summary: broken ppp-2.4.5-eaptls-mppe-0.99.patch
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: ppp
Version: 7.2
Hardware: All
OS: Linux
Target Milestone: rc
: ---
Assignee: Jaroslav Škarvada
QA Contact: qe-baseos-daemons
Depends On: 1023620
TreeView+ depends on / blocked
Reported: 2014-12-11 09:56 UTC by Michal Sekletar
Modified: 2019-12-06 16:09 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1023620
Last Closed: 2019-12-06 16:09:33 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description Michal Sekletar 2014-12-11 09:56:40 UTC
+++ This bug was initially created as a clone of Bug #1023620 +++

I just compiled ppp-2.4.5 with extra gcc compiler flag -Wlogical-op

It said

> eap.c:236:2: warning: logical 'or' of collectively exhaustive tests is always 
true [-Wlogical-op]
> eap.c:1154:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:1189:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2413:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2457:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]

It looks like the compiler is complaining about the eap_client_active macro.
It is defined in patch file ppp-2.4.5-eaptls-mppe-0.99.patch as follows

+#define    eap_client_active(esp)  ((esp)->es_client.ea_state != eapInitial ||\
+                (esp)->es_client.ea_state != eapPending ||\
+                (esp)->es_client.ea_state != eapClosed)

Suggest swap || for &&

Comment 5 David Binderman 2018-03-20 14:21:55 UTC
I just checked ppp-2.4.7 and this problem doesn't seem to exist anymore.

Presumably in the over three years since this bug report, someone
has fixed it.

Comment 6 Tomáš Hozza 2019-12-06 16:09:27 UTC
Red Hat Enterprise Linux version 7 entered the Maintenance Support 1 Phase in August 2019. In this phase only qualified Critical and Important Security errata advisories (RHSAs) and Urgent Priority Bug Fix errata advisories (RHBAs) may be released as they become available. Other errata advisories may be delivered as appropriate.

This bug has been reviewed by Support and Engineering representative and does not meet the inclusion criteria for Maintenance Support 1 Phase. If this issue still exists in newer major version of Red Hat Enterprise Linux, it has been cloned there and work will continue in the cloned bug.

For more information about Red Hat Enterprise Linux Lifecycle, please see https://access.redhat.com/support/policy/updates/errata/

Comment 7 RHEL Program Management 2019-12-06 16:09:33 UTC
Development Management has reviewed and declined this request. You may appeal this decision by using your Red Hat support channels, who will make certain  the issue receives the proper prioritization with product and development management.


Note You need to log in before you can comment on or make changes to this bug.