Bug 1023620 - broken ppp-2.4.5-eaptls-mppe-0.99.patch
Summary: broken ppp-2.4.5-eaptls-mppe-0.99.patch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ppp
Version: 20
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Michal Sekletar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1173012
TreeView+ depends on / blocked
 
Reported: 2013-10-26 07:28 UTC by David Binderman
Modified: 2015-01-07 23:56 UTC (History)
3 users (show)

Fixed In Version: ppp-2.4.5-35.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1173012 (view as bug list)
Environment:
Last Closed: 2015-01-07 23:55:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description David Binderman 2013-10-26 07:28:32 UTC
I just compiled ppp-2.4.5 with extra gcc compiler flag -Wlogical-op

It said

> eap.c:236:2: warning: logical 'or' of collectively exhaustive tests is always 
true [-Wlogical-op]
> eap.c:1154:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:1189:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2413:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2457:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]

It looks like the compiler is complaining about the eap_client_active macro.
It is defined in patch file ppp-2.4.5-eaptls-mppe-0.99.patch as follows

+#define    eap_client_active(esp)  ((esp)->es_client.ea_state != eapInitial ||\
+                (esp)->es_client.ea_state != eapPending ||\
+                (esp)->es_client.ea_state != eapClosed)

Suggest swap || for &&

Comment 1 Fedora Update System 2014-12-11 09:57:52 UTC
ppp-2.4.5-35.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ppp-2.4.5-35.fc20

Comment 2 Fedora Update System 2014-12-11 09:59:51 UTC
ppp-2.4.7-6.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/ppp-2.4.7-6.fc21

Comment 3 Fedora Update System 2014-12-13 09:37:57 UTC
Package ppp-2.4.5-35.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ppp-2.4.5-35.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-16810/ppp-2.4.5-35.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2015-01-07 23:55:15 UTC
ppp-2.4.7-6.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2015-01-07 23:56:14 UTC
ppp-2.4.5-35.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.