Bug 1034407
Summary: | add SVG rnotes support in anaconda | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | dominique <chepioq> |
Component: | anaconda | Assignee: | Chris Lumens <clumens> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 20 | CC: | alick9188, awilliam, chepioq, g.kaviyarasu, jonathan, piotrdrag, vanmeeuwen+fedora |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-06-09 16:04:37 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
dominique
2013-11-25 18:54:20 UTC
I have another question : What fonts are available in anaconda ? For example, if my svg files use Comfortaa and anaconda no, it use the default one and I don't know which (and the render will be different). I can see that anaconda don't use Comfortaa but Cantarell. I made .svg files with this fonts : https://mega.co.nz/#!BNEBAZbZ!WApOFhUSw9f-lhbYoRIwHn714n4k5YA82_SNSPYMbyU I've pushed a patch to master to look for SVG files. If they don't work during the F21 cycle, please let us know. Thank Chris But for test I think we should also change the fedora-logos package, and include the svg file in rnote directory instead of the directories with the svg files. Hi Chris and Merry Christmas... I do tests since a week, and now I have good results. I unpack the Fedora-20-x86_64-DVD.iso, and after I unpack the /Fedora-20-x86_64-DVD/LiveOS/squashfs.img in a folder (with unsquashfs squashfs.img command). I mount this unpack in other folder with "mount -o loop,rw" command. In this folder I modify: -- replace all folder in /usr/share/anaconda/pixmaps/rnotes by just one "en", with the five .svg in comment 2 in it. -- I modify /usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/hubs/progress.py with your patch (except line 31, "from pyanaconda.i18n import _, C_" I don't know why but anaconda crash with this line) After re-pack all that, I launch in a virtual machine, and that work : the .svg are displayed. I test fr, es and en. I do other test with .svg write with Comfortaa font, but this fonts are not displayed, the svg are also displayed with Cantarell fonts. I hope that test help you. I do a last test : in the unpacked squashfs.img I add in /usr/share/fonts the Comfortaa fonts and use the .svg write with that font. After repack the squashfs.img size is same that original one (271.2 Mio) and in installation all .svg show the good fonts (Comfortaa). Can you add this font in anaconda ? Hi dominique, did you test with zh_CN locale? I'm not sure if it can be displayed correctly since Comfortaa does not seem to cover characters in CJK region. (In reply to Alick Zhao from comment #7) > Hi dominique, did you test with zh_CN locale? I'm not sure if it can be > displayed correctly since Comfortaa does not seem to cover characters in CJK > region. Hi Alick I don't test with zn_CN locale because I can't choose in the window language : it's write in Chinese and I don't know this language. There are 4 choices for Chinese, zh_CN is in what position? (1 or 2 or 3 or 4) Hi Alick, I made snapshot here: http://pix.toile-libre.org/upload/original/1388127035.png zh_CN is in 1, 2, 3 or 4 position ? (In reply to dominique from comment #9) > Hi Alick, I made snapshot here: > http://pix.toile-libre.org/upload/original/1388127035.png > > zh_CN is in 1, 2, 3 or 4 position ? Hi dominique, zh_CN is the first one, i.e. the selected one in your snapshot. Hi alick, here the tarball with screen-shot of anaconda installation. One with cantarell font and other with comfortaa. Let me know which is good for you. https://mega.co.nz/#!NMUhGZZC!TVxE821_KGwne24R-xbgQgAzyEU7P3qdW80X-IU1Gz0 Hi dominique, the svg-comfortaa one looks more right to me. But I do not understand why the Chinese font is not the same in both cases. I think in both tests, there should be font substitution made by fontconfig. I think you are right, because I just add comfortaa fonts in /usr/share/fonts, but I don't made a comfortaa.conf in /usr/share/fontconfig/conf.avail. I don't know how to fill it, may-be like the cantarell.conf : <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE fontconfig SYSTEM "../fonts.dtd"> <!-- Define aliasing and other fontconfig settings for Cantarell. --> <fontconfig> <!-- Generic name assignment --> <match target="pattern"> <test qual="any" name="family"> <string>Cantarell</string> </test> <edit name="family" mode="assign" binding="weak"> <string>Cantarell</string> </edit> </match> </fontconfig> I do an other test after add a file for comfortaa in /usr/share/fontconfig/conf.avail, (file 61-aajohan-comfortaa.conf, I recovered on my fedora 20 after installed Comfortaa fonts). Result is exactly the same that the screen-shot I post in comment 11. So, um, if the point here is to save space, are we actually achieving that if we have to add comfortaa to the installer? We save ~1MB by this svg dodge, but how much extra space does comfortaa occupy? dnf says: Size : 515 k but I'm never sure if that's a measure of compressed or uncompressed size. Did you check the rendering with other fonts that are already available to the installer? @Adam Williamson I think it's the uncompressed size, because when I do test (add comfortaa font in the rootfs.img), the size of squashfs.img is the same. I do test with other fonts (Cantarell and DejaVU) and that work fine, but the rendering is not as nice. But I think it's now fixed, Brian C. Lane add comfortaa fonts in lorax package, see here : https://bugzilla.redhat.com/show_bug.cgi?id=1047430 https://git.fedorahosted.org/cgit/lorax.git/ |