Bug 1046122 (php-doctrine-collections)

Summary: Review Request: php-doctrine-collections - Collections abstraction library
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-06 17:43:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1047109, 1047111    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2013-12-23 18:33:19 UTC 
Spec URL: https://raw.github.com/siwinski/rpms/58afbf34df09331c037ce42a9f83d089708ec0ac/php-doctrine-collections.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-collections-1.1-1.20131221git8198717.fc20.src.rpm

Description:
Collections abstraction library.


Fedora Account System Username: siwinski
Comment 1 Remi Collet 2014-01-03 07:59:18 UTC 
Created attachment 844862 [details]
phpci.log

phpcompatinfo version 2.26.0.
Comment 2 Remi Collet 2014-01-03 07:59:44 UTC 
Created attachment 844863 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1046122
Comment 3 Remi Collet 2014-01-03 08:00:14 UTC 
[!]: Dist tag is present (not strictly required in GL).
  Use %{?dist}

[!]: Package does not generate any conflict.
  Conflicts:     php-pear(pear.doctrine-project.org/DoctrineCommon) < 2.4
  Both packages provides Doctrine\Common\Collections
  As /usr/share/pear is before /usr/share/php this will break
  autoloader relying on include_path.
  Also explain this package is a split-off DoctrineCommon
Comment 4 Shawn Iwinski 2014-01-03 19:29:38 UTC 
- Conditional %{?dist}
- Added conflict w/ PEAR-based DoctrineCommon pkg (version < 2.4)

Diff: https://github.com/siwinski/rpms/commit/4b409335ed63ff82a36a2dd6b9b4c6e2554e464b



Spec URL: https://raw.github.com/siwinski/rpms/4b409335ed63ff82a36a2dd6b9b4c6e2554e464b/php-doctrine-collections.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-collections-1.1-2.20131221git8198717.fc20.src.rpm
Comment 5 Remi Collet 2014-01-04 06:50:22 UTC 
[x]: Dist tag is present (not strictly required in GL).

[x]: Package does not generate any conflict.


All blocker fixed.

== APPROVED ==
Comment 6 Shawn Iwinski 2014-01-04 15:32:55 UTC 
THANKS for the review!


New Package SCM Request
=======================
Package Name: php-doctrine-collections
Short Description: Collections abstraction library
Owners: siwinski
Branches: f19 f20 el6
InitialCC:
Comment 7 Gwyn Ciesla 2014-01-06 13:19:26 UTC 
Git done (by process-git-requests).