Spec URL: https://raw.github.com/siwinski/rpms/58afbf34df09331c037ce42a9f83d089708ec0ac/php-doctrine-collections.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-collections-1.1-1.20131221git8198717.fc20.src.rpm Description: Collections abstraction library. Fedora Account System Username: siwinski
Created attachment 844862 [details] phpci.log phpcompatinfo version 2.26.0.
Created attachment 844863 [details] review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1046122
[!]: Dist tag is present (not strictly required in GL). Use %{?dist} [!]: Package does not generate any conflict. Conflicts: php-pear(pear.doctrine-project.org/DoctrineCommon) < 2.4 Both packages provides Doctrine\Common\Collections As /usr/share/pear is before /usr/share/php this will break autoloader relying on include_path. Also explain this package is a split-off DoctrineCommon
- Conditional %{?dist} - Added conflict w/ PEAR-based DoctrineCommon pkg (version < 2.4) Diff: https://github.com/siwinski/rpms/commit/4b409335ed63ff82a36a2dd6b9b4c6e2554e464b Spec URL: https://raw.github.com/siwinski/rpms/4b409335ed63ff82a36a2dd6b9b4c6e2554e464b/php-doctrine-collections.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-collections-1.1-2.20131221git8198717.fc20.src.rpm
[x]: Dist tag is present (not strictly required in GL). [x]: Package does not generate any conflict. All blocker fixed. == APPROVED ==
THANKS for the review! New Package SCM Request ======================= Package Name: php-doctrine-collections Short Description: Collections abstraction library Owners: siwinski Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).