Bug 1047109 (php-doctrine-common) - Review Request: php-doctrine-common - Common library for Doctrine projects
Summary: Review Request: php-doctrine-common - Common library for Doctrine projects
Keywords:
Status: CLOSED RAWHIDE
Alias: php-doctrine-common
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: php-doctrine-cache php-doctrine-collections php-doctrine-inflector php-doctrine-lexer php-doctrine-annotations
Blocks: php-doctrine-datafixtures php-doctrine-dbal
TreeView+ depends on / blocked
 
Reported: 2013-12-29 06:23 UTC by Shawn Iwinski
Modified: 2014-01-06 19:24 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-01-06 19:24:27 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
php-doctrine-DoctrineCommon.repoquery.txt (5.66 KB, text/plain)
2013-12-29 06:26 UTC, Shawn Iwinski 		no flags Details
phpci.log (14.62 KB, text/plain)
2014-01-04 07:35 UTC, Remi Collet 		no flags Details
review.txt (7.12 KB, text/plain)
2014-01-04 07:36 UTC, Remi Collet 		no flags Details
View All

Description Shawn Iwinski 2013-12-29 06:23:04 UTC 
Spec URL: https://raw.github.com/siwinski/rpms/1ec41e8e5728d432aacacd7eabbf75dcede2c271/php-doctrine-common.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-common-2.4.1-1.fc20.src.rpm

Description:
The Doctrine Common project is a library that provides extensions to core PHP
functionality.


Fedora Account System Username: siwinski

*** NOTE: Rename/repackage because upstream dropped PEAR packaging as of version 2.4.0
Comment 1 Shawn Iwinski 2013-12-29 06:26:24 UTC 
Created attachment 842929 [details]
php-doctrine-DoctrineCommon.repoquery.txt

repoquery of pkgs requiring php-doctrine-DoctrineCommon
Comment 2 Remi Collet 2014-01-04 07:35:29 UTC 
Created attachment 845208 [details]
phpci.log

phpcompatinfo version 2.26.0.
Comment 3 Remi Collet 2014-01-04 07:36:07 UTC 
Created attachment 845209 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047109
Comment 4 Remi Collet 2014-01-04 07:39:06 UTC 
[!]: If the package is a rename of another package, proper Obsoletes and
  Obsoletes for php-doctrine-DoctrineCommon is ok.
  You cannot obsolete php-channel-doctrine which is still used
  by old php-doctrine-Doctrine 1.2.4

[!]: UPgrade path
  Not yet ok, need dbal and orm.

[!]: Dist tag is present (not strictly required in GL).
  %{?dist}


The first is a blocker.

For upgrade patch, I will check everything is ok during the last package review.
Of course you will have to push all the packages at the same time.
Comment 5 Shawn Iwinski 2014-01-05 04:44:23 UTC 
Updates:
- Conditional %{?dist}
- Removed php-channel-doctrine obsolete

Diff: https://github.com/siwinski/rpms/commit/82df10ec8d3d744848659485a4cd1000981357a1



Spec URL: https://raw.github.com/siwinski/rpms/82df10ec8d3d744848659485a4cd1000981357a1/php-doctrine-common.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-common-2.4.1-2.fc20.src.rpm
Comment 6 Remi Collet 2014-01-05 06:05:24 UTC 
[x]: If the package is a rename of another package, proper Obsoletes and

[x]: Dist tag is present (not strictly required in GL).

== APPROVED ==
Comment 7 Shawn Iwinski 2014-01-06 04:41:34 UTC 
THANKS for the review!


New Package SCM Request
=======================
Package Name: php-doctrine-common
Short Description: Common library for Doctrine projects
Owners: siwinski
Branches: f19 f20 el6
InitialCC:
Comment 8 Gwyn Ciesla 2014-01-06 13:39:40 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.